Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firewall Policy Firewall Rule conversion in ACC - AS3 conversion - converts to "log" instead of "loggingEnabled" #96

Open
samualblair opened this issue Jan 25, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@samualblair
Copy link

samualblair commented Jan 25, 2023

Environment

  • ACC Version: 3.10.0 (current VS Code implementation)
  • AS3 Version: 3.37.0
  • BIG-IP Version: 17.0.0.1

Summary

A clear and concise description of what the bug is.
Please also include information about the reproducibility and the severity/impact of the issue.

Firewall policy configuration conversion implements "log" when required type is "loggingEnabled"

This is under class Firewall_Policy , rules, Firewall_Rule, loggingEnabled (boolean)

Steps To Reproduce

Steps to reproduce the behavior:

  1. Convert following config:
security firewall policy /Common/Test {
    rules {
        block_ping {
            action drop
            ip-protocol any
            log yes
        }
    }
}
  1. Observe the following error message:
    No error message.

Expected Behavior

I would expect valid AS3 boolean of

                            "loggingEnabled": true,

Full inline example

{
    "$schema": "https://raw.githubusercontent.com/F5Networks/f5-appsvcs-extension/master/schema/latest/as3-schema.json",
    "class": "AS3",
    "declaration": {
        "class": "ADC",
        "schemaVersion": "3.37.0",
        "id": "urn:uuid:28671c8f-0098-44be-9773-b16929e0b9fc",
        "label": "Converted Declaration",
        "remark": "Generated by Automation Config Converter",
        "Common": {
            "class": "Tenant",
            "Shared": {
                "class": "Application",
                "template": "shared",
                "Test": {
                    "rules": [
                        {
                            "action": "drop",
                            "loggingEnabled": true,
                            "name": "block_ping",
                            "protocol": "any"
                        }
                    ],
                    "class": "Firewall_Policy"
                }
            }
        }
    }
}

Actual Behavior

Instead the generated output is invalid string of

                            "log": "yes",

Full example

{
    "$schema": "https://raw.githubusercontent.com/F5Networks/f5-appsvcs-extension/master/schema/latest/as3-schema.json",
    "class": "AS3",
    "declaration": {
        "class": "ADC",
        "schemaVersion": "3.37.0",
        "id": "urn:uuid:28671c8f-0098-44be-9773-b16929e0b9fc",
        "label": "Converted Declaration",
        "remark": "Generated by Automation Config Converter",
        "Common": {
            "class": "Tenant",
            "Shared": {
                "class": "Application",
                "template": "shared",
                "Test": {
                    "rules": [
                        {
                            "action": "drop",
                            "log": "yes",
                            "name": "block_ping",
                            "protocol": "any"
                        }
                    ],
                    "class": "Firewall_Policy"
                }
            }
        }
    }
}
@samualblair samualblair added the bug Something isn't working label Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant