Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper parsing for color_t #2003

Open
mwestphal opened this issue Feb 18, 2025 · 3 comments · May be fixed by #2015
Open

Add proper parsing for color_t #2003

mwestphal opened this issue Feb 18, 2025 · 3 comments · May be fixed by #2015
Assignees
Labels
good first issue Good for newcomers help wanted Please help with this issue! source:libf3d
Milestone

Comments

@mwestphal
Copy link
Contributor

mwestphal commented Feb 18, 2025

Context
color_t option type has recently been added in libf3d, however parsing is actually the same as for double_vector.
Lets implement proper parsing of colors, such as RGB and other syntax.

Suggested solution

  • Implement proper parsing in options_tools::parse for this type
  • Check that formating is correct in options_tools::format and improve it if needed
    -Add testing in TestSDKOptions.cxx and TestSDKOptionsIO.cxx

Syntax to Support

@mwestphal mwestphal added good first issue Good for newcomers source:libf3d help wanted Please help with this issue! labels Feb 18, 2025
@mwestphal mwestphal added this to F3D Feb 18, 2025
@mwestphal mwestphal moved this to Discuss in F3D Feb 18, 2025
@mwestphal mwestphal added this to the 3.1.0 milestone Feb 18, 2025
@VittorioSanchez
Copy link

Hello, can I work on this issue?

@mwestphal
Copy link
Contributor Author

Of course!

@mwestphal mwestphal linked a pull request Mar 1, 2025 that will close this issue
@mwestphal
Copy link
Contributor Author

Being adressed in #2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Please help with this issue! source:libf3d
Projects
Status: Discuss
Development

Successfully merging a pull request may close this issue.

2 participants