Create button for copy console logs to clipboard

wergilX · wergilX · commit 62250ff5e226 · 2025-11-10T18:28:17.000+01:00
diff --git a/testing/baselines/TestInteractionConsoleAutoComplete.png b/testing/baselines/TestInteractionConsoleAutoComplete.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:ba90b6fe8378e0e7713c941f9088514ed4571bbd263b395a10d6bd1194a9a36d
-size 6253
+oid sha256:7b178773da546ebb81aafebf4bfc4236d6aa001694eb661985d31c3171c3d34e
+size 7455
diff --git a/testing/baselines/TestInteractionConsoleAutoCompleteCamera.png b/testing/baselines/TestInteractionConsoleAutoCompleteCamera.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:269835844616655ef05a637222e4f73a5dfdd32440fa56dc2f37b1eb059fe780
-size 8730
+oid sha256:8935f1a407ea374bf458f89aa73e7c607ccbff4c5c83ee36deb2a7d64ffdef8b
+size 9948
diff --git a/testing/baselines/TestInteractionConsoleAutoCompleteCandidates.png b/testing/baselines/TestInteractionConsoleAutoCompleteCandidates.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:f256f345b1fa8283239625d046fb1bc96d0e010928e0be075f7ef3969f3cb780
-size 10099
+oid sha256:ba6cd8d883da7f5593fed599fea61f6e6c22f39899fca52021b06fc89d951c11
+size 11088
diff --git a/testing/baselines/TestInteractionConsoleAutoCompleteColoring.png b/testing/baselines/TestInteractionConsoleAutoCompleteColoring.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:ce18b7cbe4f4875dd2eab782bb5a3920a42a57e9e509f6838a19a1f506aa3595
-size 17140
+oid sha256:98f986403ad7733057506cad61ffe1ed97ffbe17912cada9fafa5ce4004048d2
+size 18263
diff --git a/testing/baselines/TestInteractionConsoleAutoCompleteHelp.png b/testing/baselines/TestInteractionConsoleAutoCompleteHelp.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:041cdc7dc35c806ce324992c89556a9167c953cdb9599dcf8f2c60c040eacd02
-size 8650
+oid sha256:d9ae0d345bd9ed96952d793d9c8148ea16699791c4e0e6194fe984627a55d73e
+size 9783
diff --git a/testing/baselines/TestInteractionConsoleAutoCompleteHide.png b/testing/baselines/TestInteractionConsoleAutoCompleteHide.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:eae8378c369f4c4fee53dc205c96e70c24f8d5da789e76709782684370e67b0f
-size 3860
+oid sha256:7dfc82ac4f599f7903bd7d5003b8284c082716a425dbd8b6a85ded81a0059ba8
+size 5021
diff --git a/testing/baselines/TestInteractionConsoleAutoCompleteNoMatch.png b/testing/baselines/TestInteractionConsoleAutoCompleteNoMatch.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:d6f6dab8a60f8d1740068ea2f477fded8e4779eafdd2e30d619268ee5df6b9d5
-size 2037
+oid sha256:e65fae55c7b69cddc90af80197a0f0b5cb81530f7a8c4e008d14b31d5fb9e296
+size 3240
diff --git a/testing/baselines/TestInteractionConsoleAutoCompleteOptions.png b/testing/baselines/TestInteractionConsoleAutoCompleteOptions.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:fa266cfa443fdcff21a67154d002c9afbf7c0c0516a2f0376197d1352757beb7
-size 7338
+oid sha256:44f67b0f07750b527711de3ea6bcd0566dc5a0291f50fddb9093e306d32f0e54
+size 8511
diff --git a/testing/baselines/TestInteractionConsoleAutoCompleteReaderOptions.png b/testing/baselines/TestInteractionConsoleAutoCompleteReaderOptions.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:c516b1f87d5d621239c6bf745779c6199583ffd607d86d49943c3e386b1a9d1c
-size 10902
+oid sha256:86d4d2eea2da1e18dadd014b21f2d45ce897722bc28793a454f765e2dd528965
+size 11343
diff --git a/testing/baselines/TestInteractionConsoleClear.png b/testing/baselines/TestInteractionConsoleClear.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:3125bcebe064a6754f9b85a29640bd03d0863f1a1fb7b5b56c80c155eef181df
-size 19527
+oid sha256:d6d4b4270ff470a7bd973bddc6ef5249a24aabaa785f4af322635f10c9663543
+size 20764
diff --git a/testing/baselines/TestInteractionConsoleEmptyCommand.png b/testing/baselines/TestInteractionConsoleEmptyCommand.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:6202b5b590b3315b6f33d98fead7e6607aefc50aba76df6d6554577659ac6036
-size 5081
+oid sha256:37be7db98f463da2b356afb597604cba6fb8faeda2090e66c24db9ca91d5f4b6
+size 6219
diff --git a/testing/baselines/TestInteractionConsoleHistory.png b/testing/baselines/TestInteractionConsoleHistory.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:a12b4e708a2e9824c2bb62b32ba780a8c8a5d9108a35456e26955a523ecee49f
-size 11010
+oid sha256:359410ce256abd573e169ea0589063869fc5ba68cdbc4af7ff37fdba5cfed992
+size 12224
diff --git a/testing/baselines/TestInteractionConsoleHistoryEmpty.png b/testing/baselines/TestInteractionConsoleHistoryEmpty.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:eae8378c369f4c4fee53dc205c96e70c24f8d5da789e76709782684370e67b0f
-size 3860
+oid sha256:7dfc82ac4f599f7903bd7d5003b8284c082716a425dbd8b6a85ded81a0059ba8
+size 5021
diff --git a/testing/baselines/TestInteractionConsoleHistoryHide.png b/testing/baselines/TestInteractionConsoleHistoryHide.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:dd58c94a1cdf6dc5fa5e0aaf594c2b5326b8739dc4023ede28d18212beef326f
-size 9717
+oid sha256:1f2e86c79dcb0c4452895ba697b28c1bdfb80e3d6dd148d664c34d4a3797e740
+size 10831
diff --git a/testing/baselines/TestInteractionConsoleInvalidCommand.png b/testing/baselines/TestInteractionConsoleInvalidCommand.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:27b840621b4b8eb0533cdb2890942d905ed8384e2d6ea56a1e35a00fbe082932
-size 9205
+oid sha256:828fe5234b5d1bbb6c755c875fe63d28d94cc74e5c71bc369649c4bfa41f22a8
+size 10300
diff --git a/testing/baselines/TestInteractionConsoleInvalidOption.png b/testing/baselines/TestInteractionConsoleInvalidOption.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:1543b67773eddac9b216fefbb710c337724c91af7a66657b04b499fec20abd0f
-size 10989
+oid sha256:5e83f2b321cdb129ab56cf09797cc2599502e60731057e2b822d24f4cef319a6
+size 12136
diff --git a/testing/baselines/TestInteractionConsoleOpen.png b/testing/baselines/TestInteractionConsoleOpen.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:6202b5b590b3315b6f33d98fead7e6607aefc50aba76df6d6554577659ac6036
-size 5081
+oid sha256:37be7db98f463da2b356afb597604cba6fb8faeda2090e66c24db9ca91d5f4b6
+size 6219
diff --git a/testing/baselines/TestInteractionConsoleOpenWarningClick.png b/testing/baselines/TestInteractionConsoleOpenWarningClick.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:ca347e32caa29a0b4d35da30f998780f778c17121e55f1df119eaa5cf88316e5
-size 8865
+oid sha256:6d8440e016d2b02f96908995424f51a375edbcee6377cdd9460550ed5bbde4e0
+size 10298
diff --git a/testing/baselines/TestInteractionConsoleOpenWarningKeyboard.png b/testing/baselines/TestInteractionConsoleOpenWarningKeyboard.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:ca347e32caa29a0b4d35da30f998780f778c17121e55f1df119eaa5cf88316e5
-size 8865
+oid sha256:6d8440e016d2b02f96908995424f51a375edbcee6377cdd9460550ed5bbde4e0
+size 10298
diff --git a/testing/baselines/TestInteractionConsoleOverCheatSheet.png b/testing/baselines/TestInteractionConsoleOverCheatSheet.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:6202b5b590b3315b6f33d98fead7e6607aefc50aba76df6d6554577659ac6036
-size 5081
+oid sha256:37be7db98f463da2b356afb597604cba6fb8faeda2090e66c24db9ca91d5f4b6
+size 6219
diff --git a/testing/baselines/TestInteractionConsoleScrollbar.png b/testing/baselines/TestInteractionConsoleScrollbar.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:8eba11da3157b4de5c64cc4097ede9dfd63b5dda1daf4e65f7ca1f443649d57b
-size 9333
+oid sha256:b8f1bd9c438a64f3c0fa579be2f55923dff2fa37e6089aaaabd6f2308df2dd4c
+size 10376
diff --git a/testing/baselines/TestInteractionConsoleTypingSceneInfo.png b/testing/baselines/TestInteractionConsoleTypingSceneInfo.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:6246e54c312ba6bdbf2232fec7bbeaeffaf902de940527da55768865b4d59d8e
-size 24734
+oid sha256:e31eb48655603b1dc0254dd0534a38ad1828c01109eb7999d2abcf238864e77e
+size 25679
diff --git a/testing/baselines/TestInteractionMinimalConsoleOpen.png b/testing/baselines/TestInteractionMinimalConsoleOpen.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:d95b483995536ebe9057b70703283b29d5e59eb3a9adacc5800127a68f9507e1
-size 5100
+oid sha256:2509525611e932b03a4825f4cd2650f9b7b55dac40ec4264d3d1d591aca8877b
+size 5101
diff --git a/testing/baselines/TestInteractionMinimalConsoleOverCheatSheet.png b/testing/baselines/TestInteractionMinimalConsoleOverCheatSheet.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:e1033a1b0bcf06399789ba225fb12585fbc6ffdca523e8572eb6fdd33c9fc4ca
-size 5097
+oid sha256:2509525611e932b03a4825f4cd2650f9b7b55dac40ec4264d3d1d591aca8877b
+size 5101
diff --git a/testing/baselines/TestInteractionMinimalConsoleOverCheatSheetAndFilename.png b/testing/baselines/TestInteractionMinimalConsoleOverCheatSheetAndFilename.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:e1033a1b0bcf06399789ba225fb12585fbc6ffdca523e8572eb6fdd33c9fc4ca
-size 5097
+oid sha256:2509525611e932b03a4825f4cd2650f9b7b55dac40ec4264d3d1d591aca8877b
+size 5101
diff --git a/testing/baselines/TestInteractionMinimalConsoleResize.png b/testing/baselines/TestInteractionMinimalConsoleResize.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:bc5cb1db20d8bf41d5852f5e84e14bcdb8b212f73353cb81b83b39762972c181
-size 5306
+oid sha256:220277e32806d0381dfc379342205f5bcec673eb8ae69d1e37ac5457352b7019
+size 5310
diff --git a/testing/baselines/TestSDKConsole.png b/testing/baselines/TestSDKConsole.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:6e6e28bc61b57349e35651d43a24bc581940b5f47512eaf11de99793d757a37d
-size 6276
+oid sha256:ae468b956ccd7fce6819ca2af0b6f902302e76144dea414b49ee75b4b787dc62
+size 7325
diff --git a/vtkext/private/module/vtkF3DImguiActor.cxx b/vtkext/private/module/vtkF3DImguiActor.cxx
@@ -31,7 +31,10 @@
 #include <vtk_glew.h>
 #endif
 
+#ifdef F3D_MODULE_CLIP
 #include <clip.h>
+#endif
+
 #include <imgui.h>
 #include <numeric>
 #include <optional>
@@ -83,13 +86,20 @@ struct vtkF3DImguiActor::Internals
       io.Fonts->SetTexID((ImTextureID)this->FontTexture.Get());
 
       // Setup copy/paste callbacks
+#ifdef F3D_MODULE_CLIP
+      static std::string imgui_clipboard_storage;
+      io.ClipboardUserData = &imgui_clipboard_storage;
       io.SetClipboardTextFn = [](void* user_data, const char* text) { clip::set_text(text); };
       io.GetClipboardTextFn = [](void* user_data) -> const char*
       {
-        std::string text;
-        clip::get_text(text);
-        return text.c_str();
+        auto storage = static_cast<std::string*>(user_data);
+        if (!clip::get_text(*storage))
+        {
+          storage->clear();
+        }
+        return storage->c_str();
       };
+#endif
 
       // Create VBO
       this->VertexBuffer = vtkSmartPointer<vtkOpenGLBufferObject>::New();
diff --git a/vtkext/private/module/vtkF3DImguiConsole.cxx b/vtkext/private/module/vtkF3DImguiConsole.cxx
@@ -248,7 +248,6 @@ void vtkF3DImguiConsole::ShowConsole(bool minimal)
     this->Pimpl->ClearCompletions();          // Clear completion on hiding
     this->InvokeEvent(vtkF3DImguiConsole::HideEvent);
   }
-
   ImGui::Begin("Console", nullptr, winFlags);
 
   // Log window, will only show if not in minimal mode
@@ -360,19 +359,29 @@ void vtkF3DImguiConsole::ShowConsole(bool minimal)
     }
   }
 
-  // copy button
-  ImGui::SetCursorPos(ImVec2{ windowWidth - ImGui::CalcTextSize("Copy").x - padding * 2, padding });
-  ImGui::BeginChild("Copy button");
-  if (ImGui::Button("Copy"))
+#ifdef F3D_MODULE_CLIP
+  // the copy button doesn't work without callbacks from the clip module
+  if (!minimal)
   {
-    std::ostringstream oss;
-    for (const auto& [severity, msg] : this->Pimpl->Logs)
+    ImGui::SetCursorPos(
+      ImVec2{ windowWidth - ImGui::CalcTextSize("Copy").x - padding * 2, padding });
+    ImGui::BeginChild("Copy button");
+    ImGui::PushStyleColor(ImGuiCol_Button, ImVec4(0.25f, 0.25f, 0.25f, 1.0f));
+    ImGui::PushStyleColor(ImGuiCol_ButtonHovered, ImVec4(0.35f, 0.35f, 0.35f, 1.0f));
+    ImGui::PushStyleColor(ImGuiCol_ButtonActive, ImVec4(0.20f, 0.20f, 0.20f, 1.0f));
+    if (ImGui::Button("Copy"))
     {
-      oss << msg << '\n';
+      std::ostringstream oss;
+      for (const auto& [severity, msg] : this->Pimpl->Logs)
+      {
+        oss << msg << '\n';
+      }
+      ImGui::SetClipboardText(oss.str().c_str());
     }
-    ImGui::SetClipboardText(oss.str().c_str());
+    ImGui::PopStyleColor(3);
+    ImGui::EndChild();
   }
-  ImGui::EndChild();
+#endif
 
   ImGui::End();
 }
