Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap method of unique_span doesn't swap the deleters #703

Open
eyalroz opened this issue Jan 19, 2025 · 0 comments
Open

swap method of unique_span doesn't swap the deleters #703

eyalroz opened this issue Jan 19, 2025 · 0 comments

Comments

@eyalroz
Copy link
Owner

eyalroz commented Jan 19, 2025

In the rework of our unique_span class, for bug #678 , I've forgotten to also swap the deleters in the swap() method.

@eyalroz eyalroz added the bug label Jan 19, 2025
@eyalroz eyalroz self-assigned this Jan 19, 2025
eyalroz added a commit that referenced this issue Jan 19, 2025
…roduction of the deleter

... and using ADL for `swap()` as is idiomatic, although it's not strictly necessary.
eyalroz added a commit that referenced this issue Jan 26, 2025
…roduction of the deleter

... and using ADL for `swap()` as is idiomatic, although it's not strictly necessary.
eyalroz added a commit that referenced this issue Jan 26, 2025
…roduction of the deleter

... and using ADL for `swap()` as is idiomatic, although it's not strictly necessary.
eyalroz added a commit that referenced this issue Jan 26, 2025
…roduction of the deleter

... and using ADL for `swap()` as is idiomatic, although it's not strictly necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant