Fixed retain cycles between MacawView and MacawZoom #716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ystrot
approved these changes
Jul 17, 2020
Member
|
Looks good for me. @f3dm76 could you please review this PR as well? |
f3dm76
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
In this pull request I fixed 2 issues:
retain cycle between
MacawView and MacawZoom: both classes referenced to each other using strong reference which produced retain cycle previously.Solution is easy - just to use some weak / unowned reference.
implicit retain cycle with
onZoomChangemethod. As we know -selfis also implicitly captured when we passmethodasclosure.So instead of directly passing method name as closure -
zoom.initialize(view: self, onChange: onZoomChange)we have to wrap it into additional closure with [weak self] parameter in capture list: