Add animation layer hierarchy #568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ystrot
requested changes
May 7, 2019
Source/render/NodeRenderer.swift
Outdated
| import AppKit | ||
| #endif | ||
|
|
||
| public enum Relativity { |
Member
There was a problem hiding this comment.
Move this class to original location. NodeRenderer file is a wrong location for public class.
| // layer.backgroundColor = MColor.green.cgColor | ||
| // layer.borderWidth = 1.0 | ||
| // layer.borderColor = MColor.blue.cgColor | ||
| // sublayer.backgroundColor = MColor.green.cgColor |
ystrot
requested changes
May 29, 2019
| CATransaction.setDisableActions(true) | ||
| defer { | ||
| CATransaction.commit() | ||
| //CATransaction.flush() |
Source/events/TouchEvent.swift
Outdated
|
|
||
| private let absoluteLocation: Point | ||
| private let relativeLocation: Point // location inside the node | ||
| private let viewLocation: Point // location relative t |
Source/views/MacawView.swift
Outdated
| let inverted = node.place.invert()! | ||
| let loc = location.applying(inverted.toCG()) | ||
|
|
||
| let invertedViewPlace = self.place.invert()! |
Member
There was a problem hiding this comment.
It's a normal case when invert return nil. Please handle this case correctly.
This reverts commit a727519.
ystrot
approved these changes
Jul 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.