Skip to content

Commit d9b1cfc

Browse files
author
zach
committed
fix: select a different commit to use without tail call support
1 parent cf6a98a commit d9b1cfc

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

.github/workflows/ci.yml

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,21 +35,19 @@ jobs:
3535
TEST=$(cargo run ../hello.wasm testing "Name")
3636
echo $TEST | grep 'Hi there, Name'
3737
38-
- name: Install wasm32-wasi-ghc (7a752b58)
38+
- name: Install wasm32-wasi-ghc with no tail-call support
3939
run: |
40-
rm -rf ghc-wasm-meta ~/.ghc-wasm *.wasm
41-
git clone https://gitlab.haskell.org/ghc/ghc-wasm-meta
4240
pushd ghc-wasm-meta
43-
git reset --hard 7a752b58
41+
git checkout ada3b8fa0f763e4dccb2b1f6bbf2518bff2a7c6e
4442
FLAVOUR=9.12 ./setup.sh
4543
46-
- name: Build examples
44+
- name: Build examples with no tail-call support
4745
run: |
4846
source ~/.ghc-wasm/env
4947
make clean
5048
make
5149
52-
- name: Test call command
50+
- name: Test call command with no tail-call support
5351
run: |
5452
TEST=$(extism call ./count_vowels.wasm count_vowels --wasi --input "this is a test")
5553
echo $TEST | grep '"count":4'

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ cabal init
1414

1515
**Note**: As of [aa2d85dc](https://gitlab.haskell.org/haskell-wasm/ghc-wasm-meta/-/commit/aa2d85dccbce5e18a9ce31ac92511dcdd9a95b6c) the Wasm tail-call
1616
proposal is enabled by default. Some Wasm runtimes, like the go-sdk, don't support this yet so it might be necesarry to pin ghc-wasm-meta to
17-
[7a752b58](https://gitlab.haskell.org/haskell-wasm/ghc-wasm-meta/-/commit/7a752b582203378358ffc2224d37346ec57724a0), which is the first commit before
18-
tail-calls were enabled.
17+
[ada3b8fa](https://gitlab.haskell.org/haskell-wasm/ghc-wasm-meta/-/commit/ada3b8fa0f763e4dccb2b1f6bbf2518bff2a7c6e), which seems to be the last commit to not
18+
require tail-calls.
1919

2020
Add the library from [Hackage](https://hackage.haskell.org/package/extism-pdk) to your cabal file:
2121

0 commit comments

Comments
 (0)