Fixes #8 - Separate javascript and css from directory.html #9
Conversation
…o be compliant with content security policy
index.js
Outdated
| @@ -43,18 +43,28 @@ var defaultTemplate = join(__dirname, 'public', 'directory.html'); | |||
|
|
|||
| var defaultStylesheet = join(__dirname, 'public', 'style.css'); | |||
|
|
|||
| /*! | |||
| * Stylesheet. | |||
There was a problem hiding this comment.
This has the wrong comment.
|
The tests fail because you removed the |
| server = createServer('test/fixtures', { | ||
| 'stylesheet': __dirname + '/shared/styles.css', | ||
| 'template': __dirname + '/shared/template.html' | ||
| }); |
There was a problem hiding this comment.
Revert this change to the test; this makes the test completely different from that it was trying to test. The purpose of the test is to use a custom stylesheet with the default template.
There was a problem hiding this comment.
Those styles are still there but no longer inline but will still work when using custom templates.
There was a problem hiding this comment.
OK, then change the second part of the test to verify the custom style is there, but you MUST use the default template for this test.
There was a problem hiding this comment.
Ok I see your point will fix that
|
Closing stale pull request that has open concerns that were never addressed in follow up commits and the code no longer merges into |
Fixes #8 - Separate javascript and css from directory.html to be compliant with content security policy