-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix resolving through dynamically loaded libraries #868
Labels
Comments
ramnivas
added a commit
that referenced
this issue
Aug 2, 2023
Since we upgraded Deno, along came a newer version of Tokio, which made a (breaking change)[tokio-rs/tokio#5766] to make `EnterGuard` `!Send`. We need to use `Handle::current()` to get the current handle so those dynamically loaded libraries will work with the same runtime (see comments in subsystem_resolver.rs). Only one test in the server-aws-lambda crate was using the dynamically loaded library, so we fixed by using static loaders, instead. Filed #868
tekul
added a commit
that referenced
this issue
Aug 3, 2023
* Update to work with Deno 1.34.1 Builds against the patched_1_34_1 fork of the exograph fork which is slightly ahead of 1.34.1 on Deno's main branch. This upgrades the version of Tokio we are using, which has a (breaking change tokio-rs/tokio#5766) to make `EnterGuard` `!Send`. We need to use `Handle::current()` to get the current handle so those dynamically loaded libraries will work with the same runtime (see comments in subsystem_resolver.rs). Only one test in the server-aws-lambda crate was using the dynamically loaded library, so we fixed by using static loaders, instead. Filed #868 --------- Co-authored-by: Ramnivas Laddad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When we upgraded Deno in #867, along came a newer version of Tokio, which made a (breaking change)[https://github.com/tokio-rs/tokio/pull/5766] to make
EnterGuard
!Send
. We need to useHandle::current()
to get the current handle so those dynamically loaded libraries will work with the same runtime (see comments in subsystem_resolver.rs).We deferred the issue using static loaders in the failing test since the fix seems more involved and best handled outside of Deno upgrade changes.
@tekul
The text was updated successfully, but these errors were encountered: