Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Karls Language introduces multiple concepts #2721

Open
manumafe98 opened this issue Feb 5, 2024 · 3 comments
Open

Karls Language introduces multiple concepts #2721

manumafe98 opened this issue Feb 5, 2024 · 3 comments
Assignees
Labels
discussion x:knowledge/intermediate Quite a bit of Exercism knowledge required x:module/concept Work on Concepts x:module/concept-exercise Work on Concept Exercises x:status/claimed Someone is working on this issue

Comments

@manumafe98
Copy link
Contributor

Currently the concept exercise Karls language introduces to the concepts Generics and Lists .
But in the actual exercise you do not have a task regarding the generic concept, it's all focused on lists.
I was thinking that we should create a separate exercise for the concept Generics or add a couple of new tasks to the exercise regarding generics.

@manumafe98 manumafe98 added discussion x:knowledge/intermediate Quite a bit of Exercism knowledge required x:module/concept Work on Concepts x:module/concept-exercise Work on Concept Exercises labels Feb 5, 2024
@sanderploegsma
Copy link
Contributor

Well there are generics in this exercise: the List type has a type argument.

One thing I do agree with is that the exercise could be expand on the generics part a bit, as it currently only works on List<String>. If it also required the student to work lists containing other types, like List<Integer>, it might teach the concept a bit better.

@sanderploegsma
Copy link
Contributor

On an unrelated note: I'm not sure why the solution stub already has the private field hard-coded. It isn't required at compile time so it might be giving too much away already.

@manumafe98
Copy link
Contributor Author

manumafe98 commented Feb 5, 2024

I was thinking that instead of giving the methods straight away to the student, to have them implement them, and to have them build, expecting that the list is generic. For example:

// instead of giving this
    public boolean isEmpty() {
        return languages.isEmpty();
    }

// make them build this
    public boolean isEmpty(List<?> list) {
        return list.isEmpty();
    }

@manumafe98 manumafe98 self-assigned this Feb 15, 2024
@manumafe98 manumafe98 added the x:status/claimed Someone is working on this issue label Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion x:knowledge/intermediate Quite a bit of Exercism knowledge required x:module/concept Work on Concepts x:module/concept-exercise Work on Concept Exercises x:status/claimed Someone is working on this issue
Projects
None yet
Development

No branches or pull requests

2 participants