Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tables expand to width of display adding lots of white space between columns #807

Open
bradbell opened this issue Jan 5, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@bradbell
Copy link

bradbell commented Jan 5, 2024

Describe the bug

When I create a table, sphinx-book-theme always expands it to take of the full width of the display, unlike other sphinx themes; e.g., sphinx-rtd-theme and furo. This can result in lots of white space between columns (when the browser window is wide).

In the example below, in the file test_sphinx.git/source/conf.py, if you replace sphinx_book_theme by sphinx_rtd_theme, the table width will contract and not include a huge amount of white space before and after the second column.

Reproduce the bug

git clone https://github.com/bradbell/test_sphinx.git test_sphinx.git
cd test_sphinx.git
mkdir source/_static
git checkout sphinx_book_theme -b temp
make html
firefox build/html/index.html &

List your environment

test_sphinx.git>uname -a
Linux fedora 6.6.6-200.fc39.x86_64 #1 SMP PREEMPT_DYNAMIC Mon Dec 11 17:29:08 UTC 2023 x86_64 GNU/Linux

test_sphinx.git>python --version
Python 3.12.0

test_sphinx.git>dnf info sphinx | grep '^Version'
Version : 2.2.11

test_sphinx.git>pip list | grep sphinx-book-theme
sphinx-book-theme 1.0.1

@bradbell bradbell added the bug Something isn't working label Jan 5, 2024
@bradbell bradbell changed the title ITables expand to width of display adding lots of white space between columns Tables expand to width of display adding lots of white space between columns Jan 5, 2024
@Theowyn
Copy link

Theowyn commented Feb 16, 2024

Hi, I just came across the same problem, this should be able to be solved by adding the wrapper class that e.g furo uses.
I hope it will be implemented!
https://github.com/pradyunsg/furo/blob/01887051504bbec32e241af9cebcf5cd10f656d1/src/furo/__init__.py#L37
The table-wrapper class then needs atleast the following css overflow-x: auto;

@bradbell
Copy link
Author

bradbell commented Mar 5, 2024

I use furo instead of sphinx-book-theme for my six projects on readthedocs because of this problem; e.g.,
https://xrst.readthedocs.io/latest/

Are there any plans to fix this ?

@bosd
Copy link

bosd commented Aug 28, 2024

@Theowyn Can you please make a pull request for the fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants