Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config object for topbar buttons #479

Closed
AakashGfude opened this issue Feb 9, 2022 · 1 comment
Closed

Config object for topbar buttons #479

AakashGfude opened this issue Feb 9, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@AakashGfude
Copy link
Member

AakashGfude commented Feb 9, 2022 •
edited
Loading

Describe the problem/need and solution

Context
As pointed out by @choldgraf, top-bar buttons are at present hardcoded in the template file, with conditionals determining their presence. Each has its own separate config value. Would be ideal to assimilate them into an object, and implement a less hardcoded way to display/hide these buttons.

Solution
https://furo-topbar.readthedocs.io/en/latest/ can be used as an inspiration

Benefits

Can reduce the clutter of conditionals and duplication of html in the theme code, and make it easier for a user to read and configure as every top-bar button/action would be in one place(object).

Guide for implementation

No response

Tasks and updates

No response
@AakashGfude AakashGfude added the enhancement New feature or request label Feb 9, 2022
@AakashGfude
Copy link
Member Author

Duplicate of #470

@AakashGfude AakashGfude marked this as a duplicate of #470 Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AakashGfude