- 
                Notifications
    You must be signed in to change notification settings 
- Fork 36
Description
Context
Since the admon plugin was initially ported to mdit-py-plugins (requested in hukkin/mdformat#309), there have been requests for improvements (#96 to support collapsible admonitions, MkDocs content tabs, #114 for Github Admonitions, etc.)
In response, I've refactored the logic to make it more extensible and published new versions of mdformat-mkdocs (for the mkdocs-related code) and mdformat-admon with the extensible version of the python-markdown !!! syntax (https://github.com/KyleKing/mdformat-admon/blob/d48ca09eb3160dbfbb2c8219319cba7e63ff8e4a/mdformat_admon/mdit_plugins/_python_markdown_admon.py)
Proposal
Because there is currently duplicate implementations of the admon logic (here and in mdformat-admon), we should try to reduce the duplication. I think there are a couple of options:
- Remove the admonplugin frommdit-py-pluginsand point users to mdformat-admon if they want that functionality (we could have mdit-py-plugins raise an exception if someone tries to import with a better error or just remove entirely to reduce the maintenance burden
- Move a subset of the logic from mdformat-admoninto mdit-py-plugins (the extensible factories and updated plugin) to replace what is currently here
I don't want to add additional dependencies to mdit-py-plugins and expand the scope when this project is intended to be a direct port of the js community plugins, so my preference is for some version of Option 1.
What is your preference?
Tasks and updates
No response