Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling unwanted artefacts + folders #43

Open
chrisjsewell opened this issue Apr 4, 2020 · 2 comments
Open

Handling unwanted artefacts + folders #43

chrisjsewell opened this issue Apr 4, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@chrisjsewell
Copy link
Member

@mmcky @najuzilu @choldgraf notebooks execute in the same workspace as the artefacts .
Regarding this issue, the artefacts are not the problem, they are properly created with ipython magics and accessed. The problem is the __pycache__ folder which usually gets created with every import statement. In this case, because of the artefacts import statements, I presume..

Now, jupyter-cache specifically checks for artefacts to be a file:-
image

And in this case, __pycache__ is also passed as an artefact, which breaks the system because it is a folder.

We will need to have some checks on what gets added to the array of paths passed as artefacts to jupyter-cache

Originally posted by @AakashGfude in executablebooks/MyST-NB#122 (comment)

@chrisjsewell chrisjsewell added the enhancement New feature or request label Apr 5, 2020
@mmcky
Copy link
Member

mmcky commented Apr 8, 2020

Perhaps the best approach here is to add a filter on paths to skip known patterns like __pycache__. Is there a configuration file available for jupyter-cache that allows for these patterns to be defined at the user level?

@choldgraf
Copy link
Member

I think I might have a fix for this here: #49 but I'm not totally sure. I don't have more time to work on it today but if anybody wants to take it over and its helpful, please do so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants