Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss how to visualise historical cache records #32

Closed
choldgraf opened this issue Mar 9, 2020 · 2 comments · Fixed by #33
Closed

Discuss how to visualise historical cache records #32

choldgraf opened this issue Mar 9, 2020 · 2 comments · Fixed by #33
Labels
cli CLI specific issues discussion enhancement New feature or request

Comments

@choldgraf
Copy link
Member

In #16 I mentioned that it was a bit dis-orienting to see multiple versions of the same notebook in the cache list. This is an issue to discuss how that should be handled.

One option would be to include some kind of "Origin URI" value, to make it clear that the cache entries are pointing to the same file.

I'd actually lean towards trying to find a way to only show a single entry for a given notebook with the default list. It seems that the use-case where somebody wants to list the historical cache records of a notebook to grab one from history from the CLI would be relatively rare. To avoid this confusion, perhaps jcache cache list could have a flag like --include-history that would include historical cached items, and if not given, the cache would only show the latest version of each item.

@choldgraf choldgraf added enhancement New feature or request discussion labels Mar 9, 2020
@chrisjsewell chrisjsewell added the cli CLI specific issues label Mar 9, 2020
@chrisjsewell
Copy link
Member

only show the latest version of each item

This can be implemented,

An edge case to note is that the latest version wouldn't necessarily relate to the most up-to-date for a file, if switching between git branches.

@chrisjsewell chrisjsewell changed the title Discuss how to store historical cache records Discuss how to visualise historical cache records Mar 9, 2020
chrisjsewell added a commit that referenced this issue Mar 12, 2020
@chrisjsewell
Copy link
Member

Feel free to reopen if you don't think this fixes the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli CLI specific issues discussion enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants