Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect inclusion of a PR with a git tagged merge commit #79

Open
consideRatio opened this issue Nov 14, 2022 · 0 comments
Open

Incorrect inclusion of a PR with a git tagged merge commit #79

consideRatio opened this issue Nov 14, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@consideRatio
Copy link
Collaborator

I ended up observing a PR included in the changelog, even though it was part of the previous tagged release. To reproduce this, one can do...

github-activity --since v3.0.5 --target jupyterhub/action-k3s-helm

I would expect that PR 73 should not have been written out to the changelog.

*   76875ff - Merge pull request #74 from manics/release.md (3 months ago) <Erik Sundell>
|\  
| * c657404 - Add RELEASE.md (3 months ago) <Simon Li>
|/  
*   d3c165a - (tag: v3.0.5) Merge pull request #73 from manics/calico-3.24 (3 months ago) <Simon Li>
|\  
| * e74b367 - Changelog for v3.0.5 - 2022-08-21 (3 months ago) <Simon Li>
| * 9b2415e - Update component versions in README (3 months ago) <Simon Li>
| * 903f39c - Calico 3.24.0 (3 months ago) <Simon Li>
|/  
# v3.0.5...master@{2022-11-14}

([full changelog](https://github.com/jupyterhub/action-k3s-helm/compare/v3.0.5...1039e0fe18752d4aa4a2f8594382d343c1f9728e))

## Bugs fixed

- Calico 3.24.0 (3.23 manifest URL is broken) [#73](https://github.com/jupyterhub/action-k3s-helm/pull/73) ([@manics](https://github.com/manics))

...

A motivation to think of this as a bug is that the comparison we link to, will not include the changes part of the commit that was most recently tagged.

@consideRatio consideRatio added the bug Something isn't working label Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant