Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make an embeddable nonprofit search component #128

Open
osdiab opened this issue Mar 26, 2021 · 4 comments
Open

Make an embeddable nonprofit search component #128

osdiab opened this issue Mar 26, 2021 · 4 comments
Assignees
Labels

Comments

@osdiab
Copy link
Contributor

osdiab commented Mar 26, 2021

We already have our Partner Search API working that allows for searching any nonprofit, powered by Constructor. We can make it super simple to use it by having an embeddable/npm-installable component that consumes it. https://www.notion.so/everydotorg/Partner-API-731e285581dc47efbe306c59c139d528

@osdiab
Copy link
Contributor Author

osdiab commented Mar 26, 2021

cc @markulrich @rahulgi @wednesdave

@osdiab osdiab added the p2 label Mar 27, 2021
@martinbianchi
Copy link
Contributor

@osdiab Should we expose this component along with the Donation button and the widget? Or should we create a new package inside the repo?

@martinbianchi
Copy link
Contributor

Also, should we follow some design guideline for this one? and which would be the final goal, I mean after the user searches and select a non-profit, what should happen?
And finally, would be great to have an api-key to test it while we develop the component

@osdiab
Copy link
Contributor Author

osdiab commented Apr 2, 2021

Yep, I’m thinking these embeds could happen as sub packages here, using the same basic tech that the donate button does. Let’s hold off on actually implementing it until we set some designs for how it ought to look and spec it out a bit more, though, but should be ready to go soon. I’ll also give you a testing key shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants