Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Remove PM2 as we don't use it anymore and only reference as dep #8696

Closed
evereq opened this issue Jan 3, 2025 · 2 comments
Closed
Assignees

Comments

@evereq
Copy link
Member

evereq commented Jan 3, 2025

Check the whole project for any "pm2" and "@pm2/agent" references and remove those (e.g. in Dockerfiles and in code). We do NOT use PM2 anymore as we run all in Docker and Kubernetes and we do not recommend to use it as it changes license to AGPL and it might be problematic as dependency!

evereq added a commit that referenced this issue Jan 4, 2025
* chore(deps): remove pm2 (^5.3.1) as it's no longer needed

* chore: remove unused pm2bootstrap.ts files & commands

* chore(env): remove PM2-related variables from multiple .env files

* chore(ci): remove PM2-related secrets from YAML configuration files

* fix(cspell): typo spelling :-)

* fix(cspell): typo spelling :-)

* Update Dockerfile

---------

Co-authored-by: Ruslan Konviser <[email protected]>
@emrankamil
Copy link

I want to work on this, but I need some clarifications: Have we replaced all the functionalities provided by PM2 with Docker and Kubernetes, ensuring that removing them won’t cause any potential issues?

@evereq
Copy link
Member Author

evereq commented Jan 5, 2025

@emrankamil we already pushed PR that make it, see history of messages.
PM2 was used long ago to run multiple node processes inside single instance.
If you are not using Docker Compose or Kubernetes or any other container infra, you probably need to run PM2 to be able to distribute load to multiple node processes. If you are using any of such platforms like k8s / Docker Compose or for example AWS ECS, you do NOT need it as those platforms run multiple docker containers (e.g. pods in k8s) and load balance.

We also will add PM2 support back at later point, but using plugins / separate repo etc. So those who need it, will be able to see how to use it.

@evereq evereq closed this as completed Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants