Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Handle Custom Response for Incorrect Credentials #8549

Open
adkif opened this issue Nov 22, 2024 — with Slack · 0 comments
Open

[Fix] Handle Custom Response for Incorrect Credentials #8549

adkif opened this issue Nov 22, 2024 — with Slack · 0 comments
Assignees

Comments

Copy link
Contributor

adkif commented Nov 22, 2024

Description

Currently, when users provide incorrect credentials during login, the backend API response is displayed directly in the UI. This is not user-friendly and could expose sensitive implementation details. We need to intercept this response and display a custom error message instead.

Acceptance Criteria

  1. Replace the raw backend error response with a user-friendly error message like:

“Invalid username or password. Please try again.”

  1. Ensure error messages are localized (if i18n is in use).
  2. Handle all edge cases such as:

Incorrect format of backend error response.
Network issues or timeouts.

  1. Maintain consistency in UI design for error messages (e.g., use Nebular toastr).

Note

Ensure the HTTP interceptor (if used) does not override this custom message.
The existing login service should handle the backend response and emit the custom message via error-handling logic.

@adkif adkif added the Desktop Timer label Nov 22, 2024 — with Slack
@adkif adkif self-assigned this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant