Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yarn audit support #36

Open
neuyu opened this issue Dec 10, 2019 · 7 comments
Open

Yarn audit support #36

neuyu opened this issue Dec 10, 2019 · 7 comments
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@neuyu
Copy link

neuyu commented Dec 10, 2019

Could you support yarn audit?

@neuyu
Copy link
Author

neuyu commented Dec 10, 2019

could you support yarn aduit

@nprail
Copy link
Member

nprail commented Dec 12, 2019

There is currently a very similar project that supports yarn audit. I think it was actually a fork of this one.

https://github.com/davityavryan/yarn-audit-html

But I'm certainly open to a PR adding support for yarn audit!

@nprail nprail added enhancement New feature or request help wanted Extra attention is needed labels Dec 12, 2019
@nprail nprail changed the title yarn-lock不支持 Yarn audit support Dec 12, 2019
@nprail
Copy link
Member

nprail commented Dec 13, 2019

@davityavryan How much modification did you have to do to get yarn-audit-html to work? Would you be interested in doing a PR to merge Yarn support into npm-audit-html?

@davityavryan
Copy link

davityavryan commented Dec 15, 2019

@nprail should be pretty easy. I was thinking about doing same thing (adding support for NPM). but I was planning to create separate package and deprecate mine. would recommend same for you actually, as of naming of the package can mislead users.
but if you want, I can open PR to support yarn audit in your package. ;)

@nprail
Copy link
Member

nprail commented Dec 15, 2019

@davityavryan Yeah, I was thinking that too.

Maybe we could work together on a 2.0 under a more generic name with both npm and Yarn support?

@davityavryan
Copy link

sounds great. 👍

@nprail nprail added this to the 2.0 milestone Dec 15, 2019
@neuyu neuyu closed this as completed Dec 16, 2019
@nprail
Copy link
Member

nprail commented Dec 16, 2019

@neuyu Since we will be incorporating this into v2, please leave the issue open for now :)

@nprail nprail reopened this Dec 16, 2019
@nprail nprail mentioned this issue Dec 16, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants