-
-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] INPUT_FUNCs 'monitor' and 'monitored' are broken (python errors when trying to use) #3312
Comments
I'm taking a look at this now, so I don't mind picking it up sine I'm fixing it for my project anyways. (Inspector Caracal also mentioned writing unit tests for these - I will look to see what's needed there.) |
@scyfris I fixed the trivial |
Thanks Griatch for fixing the get issue. I'll look at converting to string for the proper fix and submitting. |
Describe the bug
Right now, monitor and monitored INPUT_FUNS seem to be broken.
There are two errors with the monitore-related functiosn in inputfuncs.py:
Needs to be
This throws the error:
Looking into a bit more, it seems the the call
returns a list of things that can't all be pickleable , in particular the 'session' entry . An example of a call would be below:
Changing that to:
Works fine.
Note sure the proper fix yet - just logging here for now.
To Reproduce
Use any client and test with the following:
For the monitored issue, just send a "monitored" command after monitoring some value from the client. THIS REQUIRES A FIX TO THE ABOVE FIRST! You will see an error in logs/server.log indicated earlier in this bug.
Expected behavior
Things should work without python errors .
Environment, Evennia version, OS etc
NOTE: I am using a custom client , but I'm not doing anything custom about these INPUT_FUNCS.
The text was updated successfully, but these errors were encountered: