Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced transaction simulations #501

Open
5 tasks done
naps62 opened this issue Nov 15, 2023 · 2 comments
Open
5 tasks done

Enhanced transaction simulations #501

naps62 opened this issue Nov 15, 2023 · 2 comments
Labels
epic A high-level tracker for a broad feature

Comments

@naps62
Copy link
Member

naps62 commented Nov 15, 2023

The wallet already provides simulations automatically whenever a transaction review dialog pops up:

image

We want to improve the capabilities of this dialog, and of simulations as a whole.

Key points (each of which can be its own PR):

  • Ability to customize all aspects of a transaction during the dialog (gas, data, value, etc), and see that reflected in the simulation output in near-real time
  • Ability to see the decoded call data, based on ABI information, with all the arguments being used, and the ability to edit them as well (e.g.: edit the amount of an ERC20 transaction), and just like above, see the real-time feedback in the simulation output
  • Show more intelligent information based on the output: ERC20 transfers, ERC721 transfers, ERC20 approval changes.
  • Detect if the destination contract is one we haven't interacted with before, or has been deployed recently, and display a warning in such cases (Adds previous call count to tx review dialog #610 )
  • Ability to select a transaction from the wallet's history, and ask to "send it again", filling in the dialog & simulation with those parameters. This may be useful mostly for developers wanting to take repeated actions, or test the same interaction with slightly different params (Ability to re-send transactions #611 )
@naps62 naps62 added the epic A high-level tracker for a broad feature label Nov 15, 2023
@ABZerra
Copy link

ABZerra commented Nov 16, 2023

Nothing to add, looks awesome.

@naps62
Copy link
Member Author

naps62 commented Apr 27, 2024

Being finalized in #661 with the ability to edit individual tx fields

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic A high-level tracker for a broad feature
Projects
None yet
Development

No branches or pull requests

2 participants