Skip to content

Inject traceId into the loggers of the packages #2074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
manuelwedler opened this issue Apr 14, 2025 · 4 comments · May be fixed by #2112
Open

Inject traceId into the loggers of the packages #2074

manuelwedler opened this issue Apr 14, 2025 · 4 comments · May be fixed by #2112
Assignees
@manuelwedler
Labels
lib-sourcify packages

Comments

@manuelwedler
Copy link
Contributor

manuelwedler commented Apr 14, 2025 •
edited
Loading

Currently, only server logs have the traceId injected for GCP. I wanted to follow the logs of a request starting from a compilers log, which is not easy without the traceId. We should also inject it into the loggers of lib-sourcify and compilers packages.
Edit: This is only a problem of compilers package.
@kuzdogan kuzdogan moved this from Triage to Sprint - Up Next in Sourcify Public Apr 14, 2025
@kuzdogan
Copy link
Member

kuzdogan commented Apr 14, 2025 •
edited
Loading

Also debug the situation with undefined traces in GCP

@kuzdogan
Copy link
Member

You can also do a general logs review if they contain enough information, such as the parameters (chainId address etc.) after the new release

@manuelwedler manuelwedler moved this from Sprint - Up Next to Sprint - In Progress in Sourcify Public Apr 24, 2025
@manuelwedler
Copy link
Contributor Author

The problem about no traces in compilers package was fixed by #2100

@manuelwedler
Copy link
Contributor Author

Also debug the situation with undefined traces in GCP

There are three kinds of logs that have an undefined trace:

  1. Monitor logs
  2. Server initialization logs (during startup, not related to a request)
  3. Server's verification worker logs

I think for 1. and 2. it's okay to leave them with an undefined trace.

For 3., I'm implementing a fix at the moment.

@manuelwedler manuelwedler linked a pull request Apr 24, 2025 that will close this issue
Open
@manuelwedler manuelwedler moved this from Sprint - In Progress to Sprint - Needs Review in Sourcify Public Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manuelwedler manuelwedler

Labels
lib-sourcify packages
Projects
Sourcify Public
Status: Sprint - Needs Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set logLevel and inject traceIds in verificationWorker threads ethereum/sourcify
2 participants
@kuzdogan @manuelwedler