Skip to content

Implement unit tests for the AllianceDatabaseService #2022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manuelwedler opened this issue Mar 20, 2025 · 0 comments
Open

Implement unit tests for the AllianceDatabaseService #2022

manuelwedler opened this issue Mar 20, 2025 · 0 comments
Labels

Comments

@manuelwedler
Copy link
Contributor

Writing to the VerA db was broken after one release, because we use a different constraint in contract_deployments on Sourcify matches now. If we would had tests for the AllianceDatabaseService we would have caught this problem before the release. Therefore, we should implement tests for all functions of the AllianceDatabaseService.

I would implement these as unit tests and not run the verification through the server API. Just calling the functions on a AllianceDatabaseService instance should be good for catching the errors we had.

Maybe we can generalize these unit tests, such that we can also run it with the SourcifyDatabaseService.

Related

Fix for the constraint to work with both dbs: #2020

@manuelwedler manuelwedler moved this from Triage to Sprint - Candidates in Sourcify Public Mar 20, 2025
@manuelwedler manuelwedler moved this from Sprint - Candidates to Backlog in Sourcify Public Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog
Development

No branches or pull requests

1 participant