You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Writing to the VerA db was broken after one release, because we use a different constraint in contract_deployments on Sourcify matches now. If we would had tests for the AllianceDatabaseService we would have caught this problem before the release. Therefore, we should implement tests for all functions of the AllianceDatabaseService.
I would implement these as unit tests and not run the verification through the server API. Just calling the functions on a AllianceDatabaseService instance should be good for catching the errors we had.
Maybe we can generalize these unit tests, such that we can also run it with the SourcifyDatabaseService.
Related
Fix for the constraint to work with both dbs: #2020
The text was updated successfully, but these errors were encountered:
Writing to the VerA db was broken after one release, because we use a different constraint in
contract_deployments
on Sourcify matches now. If we would had tests for theAllianceDatabaseService
we would have caught this problem before the release. Therefore, we should implement tests for all functions of theAllianceDatabaseService
.I would implement these as unit tests and not run the verification through the server API. Just calling the functions on a
AllianceDatabaseService
instance should be good for catching the errors we had.Maybe we can generalize these unit tests, such that we can also run it with the
SourcifyDatabaseService
.Related
Fix for the constraint to work with both dbs: #2020
The text was updated successfully, but these errors were encountered: