Skip to content

Add sourceIds field to v2 lookup #2007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
manuelwedler opened this issue Mar 18, 2025 · 1 comment · Fixed by #2060
Closed

Add sourceIds field to v2 lookup #2007

manuelwedler opened this issue Mar 18, 2025 · 1 comment · Fixed by #2060
Assignees
@manuelwedler
Labels
server

Comments

@manuelwedler
Copy link
Contributor

Following a suggestion on Matrix chat, we should add a field sourceIds on the highest level of the response of the v2/contract/:chainId/:address endpoint. It should contain the source file ids as in the standard json output. It should return a mapping of type Record<string, { id: number }>, where the keys are the file paths.

It should be optional and only be returned if queried via ?fields.
@kuzdogan
Copy link
Member

Just to make sure, it should also be returned with "all"

@kuzdogan kuzdogan moved this from Triage to Backlog in Sourcify Public Mar 25, 2025
@manuelwedler manuelwedler moved this from Backlog to Sprint - Up Next in Sourcify Public Mar 31, 2025
@manuelwedler manuelwedler self-assigned this Mar 31, 2025
@manuelwedler manuelwedler moved this from Sprint - Up Next to Sprint - In Progress in Sourcify Public Apr 7, 2025
@manuelwedler manuelwedler mentioned this issue Apr 8, 2025
Merged
@manuelwedler manuelwedler moved this from Sprint - In Progress to Sprint - Needs Review in Sourcify Public Apr 8, 2025
@github-project-automation github-project-automation bot moved this from Sprint - Needs Review to Sprint - Done in Sourcify Public Apr 8, 2025
@marcocastignoli marcocastignoli moved this from Sprint - Done to COMPLETED in Sourcify Public Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manuelwedler manuelwedler

Labels
server
Projects
Sourcify Public
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add sourceIds field to v2 lookup ethereum/sourcify
2 participants
@kuzdogan @manuelwedler