Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug report: missing image on list of wallets page #14530

Open
1 of 2 tasks
konopkja opened this issue Dec 19, 2024 · 4 comments · May be fixed by #14532
Open
1 of 2 tasks

Bug report: missing image on list of wallets page #14530

konopkja opened this issue Dec 19, 2024 · 4 comments · May be fixed by #14532
Assignees
@HiberNuts
Labels
bug 🐛 Something isn't working dev required This requires developer resources good first issue Good item to try if you're new to contributing

Comments

@konopkja
Copy link
Contributor

Describe the bug

missing image

To reproduce

  1. Go to https://ethereum.org/en/wallets/find-wallet/
  2. Scroll to Metamask
  3. see missing image

Expected behavior

NA

Screenshots

Screenshot 2024-12-19 at 13 53 37

Desktop (please complete the following information)

No response

Smartphone (please complete the following information)

No response

Additional context

No response

Would you like to work on this issue?

  • Yes
  • No
@konopkja konopkja added the bug 🐛 Something isn't working label Dec 19, 2024
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Dec 19, 2024
@konopkja konopkja added good first issue Good item to try if you're new to contributing dev required This requires developer resources and removed needs triage 📥 This issue needs triaged before being worked on labels Dec 19, 2024
@HiberNuts
Copy link

Would love to fix this, please assign to me

@konopkja
Copy link
Contributor Author

Assigned!

@HiberNuts
Copy link

The missing image belongs to Taiko Mainnet for which no respoective network is added in network data - refer to network.ts in src/data/networks/network.ts.
Do you want me to add a new network following the same pattern as other networks?

@HiberNuts HiberNuts linked a pull request Dec 19, 2024 that will close this issue
Open
@HiberNuts
Copy link

Please refer to the PR #14532

Description

Fixes #14530

This PR resolves the missing wallet image issue on the Find Wallet page by adding the required network data for Taiko Mainnet in the network configuration.

Changes Made

  • Added Taiko Mainnet network configuration in src/data/networks/network.ts
  • Fixed missing wallet image display on the Find Wallet page

Screenshots

Before
image
After
image

Testing Instructions

  1. Navigate to https://ethereum.org/en/wallets/find-wallet/
  2. Scroll to the wallet section and find MetaMask
  3. Verify that the previously missing image is now displayed correctly

Additional Notes

  • Follows existing network configuration pattern
  • No breaking changes introduced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HiberNuts HiberNuts

Labels
bug 🐛 Something isn't working dev required This requires developer resources good first issue Good item to try if you're new to contributing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add missing wallet image for Taiko Mainnet HiberNuts/ethereum-org-website
2 participants
@HiberNuts @konopkja