Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarifications on ERC-3156 flash loan implementation #518

Open
BigGod12 opened this issue Jul 7, 2024 · 2 comments
Open

clarifications on ERC-3156 flash loan implementation #518

BigGod12 opened this issue Jul 7, 2024 · 2 comments

Comments

@BigGod12
Copy link

BigGod12 commented Jul 7, 2024

Hi while reading through https://github.com/ethereum/ercs/blob/master/ERCS/erc-3156.md
is it advisable to use reentrance guard for the flash loan function within the contract implementing the "flash lender" interface??
even if the "receiver" contract call back within the onFlashloan to take more loan.. though the transaction should revert if the "REENTER" amount was not repaid but the first initial loan was repaid. since there is two race window "flash loan" that must be repaid.
this blog https://www.rareskills.io/post/erc-3156 suggest using "nonReentrant" for security purposes. but i see no reason for that.

@poojaranjan
Copy link

Please add your question at FEM Discussion to get the author's attention or response from an EIP implementer/expert.

@BigGod12
Copy link
Author

Please add your question at FEM Discussion to get the author's attention or response from an EIP implementer/expert.

oh. thank you for the information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants