Skip to content

interop: contracts: remove useInterop from L2Genesis.s.sol #16075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
protolambda opened this issue May 22, 2025 · 0 comments · May be fixed by #16095
Open

interop: contracts: remove useInterop from L2Genesis.s.sol #16075

protolambda opened this issue May 22, 2025 · 0 comments · May be fixed by #16095
Assignees
@ajsutton
Labels
A-pkg-contracts-bedrock Area: packages/contracts-bedrock H-interop Hardfork: change planned for interop upgrade T-smart-contract Team: changes to smart contracts implemented by solidity devs

Comments

@protolambda
Copy link
Contributor

protolambda commented May 22, 2025 •
edited
Loading

  • Change the L2Genesis.s.sol script to insert the interop predeploys if, and only if:
    • The interop fork is active (just like the fork checks of holocene/isthmus/etc.)
    • Some special flag is set that the cross-l2-inbox may be initialized at genesis. We do not want the inbox contract to be active when the chain only upgraded to interop and has an empty dependency set.
      • Note: unlike useInterop , the flag should only apply to the inbox precompile proxy state, to match the upgrade-activation logic.
  • Remove useInterop from the opcm Go struct that feeds into the L2Genesis.s.sol execution, and replace it with above mentioned flag, here:

    optimism/op-deployer/pkg/deployer/pipeline/l2genesis.go

    Line 96 in 12c5398

    UseInterop: intent.UseInterop,
@protolambda protolambda added A-pkg-contracts-bedrock Area: packages/contracts-bedrock T-smart-contract Team: changes to smart contracts implemented by solidity devs H-interop Hardfork: change planned for interop upgrade labels May 22, 2025
@protolambda protolambda mentioned this issue May 22, 2025
Merged
@ajsutton ajsutton linked a pull request May 23, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajsutton ajsutton

Labels
A-pkg-contracts-bedrock Area: packages/contracts-bedrock H-interop Hardfork: change planned for interop upgrade T-smart-contract Team: changes to smart contracts implemented by solidity devs
Projects
Protocol Team
Status: Backlog
Milestone
No milestone
2 participants
@ajsutton @protolambda