Skip to content

Commit 4f43bd9

Browse files
authored
op-challenger: fail immediately if VmBin and Server don't exist (#13588)
* ensure VmBin and Server exist * only check when not in test * test file exists * reuse TempDir() * add tests for new errors * address comments
1 parent 38aa19f commit 4f43bd9

File tree

2 files changed

+187
-78
lines changed

2 files changed

+187
-78
lines changed

op-challenger/config/config.go

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import (
44
"errors"
55
"fmt"
66
"net/url"
7+
"os"
78
"runtime"
89
"slices"
910
"strconv"
@@ -216,6 +217,14 @@ func (c Config) Check() error {
216217
if c.Cannon.Server == "" {
217218
return ErrMissingCannonServer
218219
}
220+
221+
if _, err := os.Stat(c.Cannon.VmBin); err != nil {
222+
return fmt.Errorf("%w: %w", ErrMissingCannonBin, err)
223+
}
224+
if _, err := os.Stat(c.Cannon.Server); err != nil {
225+
return fmt.Errorf("%w: %w", ErrMissingCannonServer, err)
226+
}
227+
219228
if c.Cannon.Network == "" {
220229
if c.Cannon.RollupConfigPath == "" {
221230
return ErrMissingCannonRollupConfig
@@ -254,6 +263,14 @@ func (c Config) Check() error {
254263
if c.Asterisc.Server == "" {
255264
return ErrMissingAsteriscServer
256265
}
266+
267+
if _, err := os.Stat(c.Asterisc.VmBin); err != nil {
268+
return fmt.Errorf("%w: %w", ErrMissingAsteriscBin, err)
269+
}
270+
if _, err := os.Stat(c.Asterisc.Server); err != nil {
271+
return fmt.Errorf("%w: %w", ErrMissingAsteriscServer, err)
272+
}
273+
257274
if c.Asterisc.Network == "" {
258275
if c.Asterisc.RollupConfigPath == "" {
259276
return ErrMissingAsteriscRollupConfig
@@ -289,6 +306,14 @@ func (c Config) Check() error {
289306
if c.AsteriscKona.Server == "" {
290307
return ErrMissingAsteriscKonaServer
291308
}
309+
310+
if _, err := os.Stat(c.AsteriscKona.VmBin); err != nil {
311+
return fmt.Errorf("%w: %w", ErrMissingAsteriscKonaBin, err)
312+
}
313+
if _, err := os.Stat(c.AsteriscKona.Server); err != nil {
314+
return fmt.Errorf("%w: %w", ErrMissingAsteriscKonaServer, err)
315+
}
316+
292317
if c.AsteriscKona.Network == "" {
293318
if c.AsteriscKona.RollupConfigPath == "" {
294319
return ErrMissingAsteriscKonaRollupConfig

0 commit comments

Comments
 (0)