Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project with facebook.shimmer as io.shimmer.supercharge is not upgrading and has jerks #36

Open
usmanrana07 opened this issue Sep 25, 2019 · 2 comments

Comments

@usmanrana07
Copy link

You should now use 'https://github.com/team-supercharge/ShimmerLayout' instead of ('https://github.com/team-supercharge/ShimmerLayout') , because supercharge has jerks in Android 9 version and is not being updated from years, while facebook is updating its library, and doesn't has jerks.

@usmanrana07
Copy link
Author

I've modified your code to replace shimmer library with faceook shimmer, Go through the code if you feel ok, we can merge he code at your code: https://github.com/usmanrana07/Skeleton

@SkywalkerDarren
Copy link

I fork it and migrate to Kotlin, AndroidX, and shimmer-android.
https://github.com/SkywalkerDarren/Skeleton

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants