Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate sepecifying disk type/peformance in Prow #19493

Open
serathius opened this issue Feb 26, 2025 · 3 comments
Open

Investigate sepecifying disk type/peformance in Prow #19493

serathius opened this issue Feb 26, 2025 · 3 comments

Comments

@serathius
Copy link
Member

What would you like to be added?

Let's investigate if we can configure Prow to provide us disk with better performance. For etcd we recommend SSD, so for performance heavy tests we should use it.

I heard that Kubernetes Node tests run on VM, in that setup it should be possible to attach disk.
We should investigate how those test run.

Why is this needed?

Great for robustness and benchmarks to get stable performance

@kavirajk
Copy link

@serathius Checking the prow doc, looks like we can set some presets with volume that may use ssd based pvc? And we can add those presets in our Prow jobs for etcd here?.

Something like

volumes:
      - name: ssd-volume
        persistentVolumeClaim:
          claimName: ssd-pvc

New to Prow. Assuming this is where all the Prow jobs for etcd is stored?

@serathius
Copy link
Member Author

And we can add those presets in our Prow jobs for etcd here?.

Should good, please coordinate with @ivanvc and @BenTheElder

New to Prow. Assuming this is where all the Prow jobs for etcd is stored?

Yes

@ivanvc
Copy link
Member

ivanvc commented Feb 27, 2025

@BenTheElder (or probably better to reach out in #sig-testing), could shed some light on what we need to do to define and have access to a PVC.

Should we worry that the PVC may become a bottleneck, as we may not have the pod schedule because it'll be waiting on the PVC? Unless we can create ephemeral PVCs, or alternatively, enable this only for periodic jobs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants