[Feature request] [Alarms] Put hidden alarms in submenu

[thyttan]

Description

Add a submenu to the Alarms app called "Hidden alarms" where all alarms with the hidden attribute set are relegated to.

Background

EDIT: I realized I should not add 27 Alarms but just keep adjusting/snoozing a singel alarm instead. Making this feature request not feel as important.

I'm trying out refactoring the twenties app (vibrate the watch every 20 mins to stand up and rest your eyes) to use the scheduling library to setup vibration intervals. Instead of using it's own setTimeout calls. This adds 27 new "hidden" alarms that should be set and forget. Today that makes the main menu of the Alarms app crowded and noticeably slower to load. Filtering out hidden alarms would help with accessing alarms I actually want to interact with on a more regular basis. And hopefully speed up loading the menu too?

Diff against master here: https://github.com/espruino/BangleApps/compare/master...thyttan:BangleApps:twenties?expand=1

Considerations

Is the way of using the scheduling library as I describe above in the background section a good or bad idea? Will adding a bunch of alarms that way lead to unwanted slowdowns when parsing alarms in other places (e.g. during boot b/w loads)? Maybe it's better to just keep using setTimeout to not introduce complexity in a bunch of places?

Instead of using the hidden attribute (that today just hides that alarms widget AFAIK) should a new attribute be introduced for hiding it from the main menu?

I'm curious to hear your thoughts on this @gfwilliams when you have the time.

[thyttan]

For the twenties app I realized I should not add 27 Alarms but just keep adjusting/snoozing a single alarm instead. Making this feature request not feel as important.

[gfwilliams]

Yes, definitely having the one alarm you reschedule sounds good!

But as you say it looks like it would be a good idea to make hidden hide alarms/timers from the menu (if it's set). It looks like the only app that actually uses hidden is smpltimer and it makes sense to hide it in that case?

I'd say maybe make showMainMenu hide alarms by default, and then add an option to show them in showAdvancedMenu? https://github.com/espruino/BangleApps/blob/master/apps/alarm/app.js#L563

Also looking at it, there is an option to show alarm groups which could help in the case you mention. Although looking at the code there was a bug plus it's undocumented in sched and defaults to false so I wonder how well the option actually works! I've tried to put a fix in though

edit: so actually just setting group:"Hidden" would have a very similar effect to what you want (if showGroups was the default)

[thyttan]

Ah - nice. Thanks! I think that covers most of it yes. If I feel like it I may implement the option to hide 'hidden' alarms from showMainMenu.