Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preact/hooks not respecting external? #871

Open
dreiss opened this issue Aug 29, 2024 · 1 comment
Open

preact/hooks not respecting external? #871

dreiss opened this issue Aug 29, 2024 · 1 comment
Assignees
Labels
browser Not working in Browser

Comments

@dreiss
Copy link

dreiss commented Aug 29, 2024

Failing module

Loading from the url https://esm.sh/*preact/hooks with curl, I get redirected to https://esm.sh/*[email protected]/hooks, which looks like

/* esm.sh - [email protected]/hooks */
import "/stable/[email protected]/esnext/preact.mjs";
export * from "/stable/[email protected]/esnext/hooks.js";

and https://esm.sh/stable/[email protected]/esnext/hooks.js starts with import{options as V}from"/stable/[email protected]/esnext/preact.mjs";

My understanding from the esm.sh docs was that the "*" at the start of the package name was supposed to make all references external so they would be resolved by import maps.

@dreiss dreiss added the browser Not working in Browser label Aug 29, 2024
@ije
Copy link
Member

ije commented Aug 29, 2024

i think this is a bug of the build resolver, i will look into it

@ije ije self-assigned this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser Not working in Browser
Projects
None yet
Development

No branches or pull requests

2 participants