feat: rule no-unsafe-values #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nzakas
requested changes
Oct 4, 2024
There was a problem hiding this comment.
This looks like a good start. Some high-level notes:
- Please add this rule to the rules table on the README
- Please add this rule to the recommended configuration
Also, it looks like your last invalid test is actually producing two errors instead of one. Can you double-check that?
| if (match[0].length < 2) { | ||
| context.report({ | ||
| loc: node.loc, | ||
| messageId: "loneSurrogate", |
There was a problem hiding this comment.
Because we're not showing the actual location of the lone surrogate, can we show the surrogate itself? That would give folks a bit more information about where the problem is.
Co-authored-by: Nicholas C. Zakas <[email protected]>
Comment on lines
+67
to
+73
| { | ||
| messageId: "loneSurrogate", | ||
| line: 1, | ||
| column: 1, | ||
| endLine: 1, | ||
| endColumn: 4, | ||
| }, |
There was a problem hiding this comment.
Can you add data to all test errors with messageId: "loneSurrogate"?
|
@bmeck just one outstanding comment to address here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Introduce a new rule for checking common interchange problems
What changes did you make? (Give an overview)
Added a rule for:
Related Issues
fixes #29
Is there anything you'd like reviewers to focus on?
tests are somewhat limited by using already parsed values so I avoided trying to reparse for getting exact locations within strings and/or couldn't check array/string bounds since things error before getting to the rules processing phase.