feat: no-case-declarations add suggestions
#18388
Merged
+260
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint canceled.
|
mdjermanovic
added
the
accepted
mdjermanovic
previously approved these changes
Apr 24, 2024
There was a problem hiding this comment.
LGTM, thanks!
Leaving it open as, per our policies, it requires at least one additional approval from any other team member (because this is a new feature), and also a waiting period of 2 days before merging.
|
When a declared identifier is used in another // ecmaVersion: "latest"
switch ("foo") {
case "bar":
function baz() { }
break;
default:
baz();
}compared to: // ecmaVersion: "latest"
switch ("foo") {
case "bar":
{ function baz() { }
break; }
default:
baz(); // TypeError!
}I assume this is acceptable for a suggestion, but maybe we should add a unit test to show that we are aware of the risk and we know what we are doing? |
fasttime
approved these changes
Apr 25, 2024
mdjermanovic
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[x] Add
autofixsuggestion to a rule[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Fixes #18349
What changes did you make? (Give an overview)
Adds a suggestion fixer to
no-case-declarationsto add{}brackets around blocks.Also adds a couple new tests to make sure switches with multiple violating cases report on the right case (consequent).
Is there anything you'd like reviewers to focus on?
I'd considered adding logic for friendlier
{}bracket placement but then decided against the added complexity.