Merged
Conversation
|
Looks great!
I think so. I had the same thought before seeing this PR. |
Member
Author
|
@fasttime I can't quite figure out why the type tests are failing now. Can you take a look? |
Member
Author
|
@jeddy3 thanks, updated! |
Member
Author
|
I think I figured out the types issue: #28 |
fasttime
reviewed
Dec 5, 2024
Member
Author
|
I fixed the bug in CSS Tree with layer positioning. Just waiting for a new release to update this PR. |
fasttime
added
the
accepted
jeddy3
reviewed
Dec 6, 2024
There was a problem hiding this comment.
I've added two suggestions for extra tests.
I think I'd find it more intuitive if the boolean options matched, i.e. both made the rule stricter or more permissive.
For example, either:
allowUnnamedLayers: falseallowUnLayeredImports: false
or:
requireNamedLayers: truerequireImportLayers: true
Member
Author
|
With CSSTree updated, all of the locations are now correct. 🎉 |
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Add a new
use-layersruleWhat changes did you make? (Give an overview)
use-layersruleNote: This rule is not recommended because it will likely only be useful on a subset of CSS files in any given project.
Related Issues
fixes #18
Is there anything you'd like reviewers to focus on?
ShouldYes!@importrequire a layer by default? Right now it doesn't, but I feel like maybe it should.