Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint-config-standard-with-typescript deprecated, moved to eslint-config-love #95

Closed
tabcat opened this issue Apr 12, 2024 · 4 comments · Fixed by #108
Closed

eslint-config-standard-with-typescript deprecated, moved to eslint-config-love #95

tabcat opened this issue Apr 12, 2024 · 4 comments · Fixed by #108

Comments

@tabcat
Copy link

tabcat commented Apr 12, 2024

Getting a deprecation warning after running npm init @eslint/config

Screenshot from 2024-04-12 00-11-10

The deprecation messages says to use eslint-config-love package instead. It looks like the https://github.com/mightyiam/eslint-config-standard-with-typescript repo has been renamed to eslint-config-love and has the same exact purpose. Could not find any other references or reasoning for the deprecation.



If this is all that needs to be changed, I'd be happy to open a PR.

{ message: "Standard: https://github.com/standard/eslint-config-standard-with-typescript", name: "standard", value: { packageName: "eslint-config-standard-with-typescript", type: "eslintrc" } },

const tsStyleGuides = [
-    { message: "Standard: https://github.com/standard/eslint-config-standard-with-typescript", name: "standard", value: { packageName: "eslint-config-standard-with-typescript", type: "eslintrc" } },
+    { message: "Standard: https://github.com/mightyiam/eslint-config-love", name: "standard", value: { packageName: "eslint-config-love", type: "eslintrc" } },
     { message: "XO: https://github.com/xojs/eslint-config-xo-typescript", name: "xo", value: { packageName: "eslint-config-xo-typescript", type: "eslintrc" } }
 ];
@Delapouite
Copy link

Thanks. A related question: should there be a possibility to select None during this question of the initialization wizard?

@aladdin-add
Copy link
Member

aladdin-add commented Apr 18, 2024

A related question: should there be a possibility to select None during this question of the initialization wizard?

  1. the question won't be asked when you select 1/2:
? How would you like to use ESLint? … 
  To check syntax only
❯ To check syntax and find problems
  To check syntax, find problems, and enforce code style
  1. when using the --config, it means "just use this shared config, don't ask any questions". you can see it in the readme.

@aladdin-add
Copy link
Member

The brand standard no longer seems applicable; since it's a new brand, I believe we can simply remove it. / @voxpelli

@voxpelli
Copy link

See standard/standard#1957 and standard/standard#1948

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging a pull request may close this issue.

4 participants