Skip to content

Beta-testers needed #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
erykjj opened this issue Jan 6, 2025 · 35 comments
Closed

Beta-testers needed #205

erykjj opened this issue Jan 6, 2025 · 35 comments
Assignees

Comments

@erykjj
Copy link
Owner

erykjj commented Jan 6, 2025

Please let me know if you are able to collaborate by doing some beta-testing. This will include trying out new functionality and doing all kinds of things to try to break the app, and reporting the results.

I will need to know what OS you can test on.

@erykjj erykjj pinned this issue Jan 6, 2025
@glenmwright
Copy link

Hi Eryk, I am always happy to test on Windows.

@erykjj
Copy link
Owner Author

erykjj commented Jan 10, 2025

https://github.com/erykjj/jwlmanager/releases/tag/v7.0.0-beta1

I have implemented direct merge of two archives: just drag-and-drop a second one into the app while you have one opened and you will have the option to open it or merge it into the first (over-writing any at the same location and with the same title).

As a result, I have adjusted some of the export and import functions (and fixed some minor issues).

I need systematic testing of exporting and importing all the different categories (Notes, Highlights, Annotations, Bookmarks, Favorites).

Please focus on one category at a time, and just one or two items, to ensure that the resulting archive is as expected.

Thank you!

@erykjj
Copy link
Owner Author

erykjj commented Jan 11, 2025

v7.0.0-beta2

  • Full merge of all items (including Playlists)

@skybird-dev
Copy link

I can test on iOS, iPadOS, and macOS (Apple Silicon)

@erykjj
Copy link
Owner Author

erykjj commented Jan 12, 2025

Hi @skybird-dev

Thank you! Please grab the latest v7 beta from here: https://github.com/erykjj/jwlmanager/releases

I can't build for iOS, but there is a macOS build.

Thanks again!

@glenmwright
Copy link

Good morning,

I have done some small file merging and it is working. Working with larger files seems to hang at 40%, or perhaps I am not patient enough to wait. I have learned that when I kill the task, I have to delete the lock file for the program to start again.

However, the Export to Excel is failing in 7.0 but works in 6.1.2.

JWLManager v7.0.0
Windows-10-10.0.19045-SP0

Traceback (most recent call last):
File "JWLManager.py", line 1418, in export_items
File "JWLManager.py", line 1202, in export_notes
File "JWLManager.py", line 930, in create_xlsx
NameError: cannot access free variable 'item_list' where it is not associated with a value in enclosing scope

@erykjj
Copy link
Owner Author

erykjj commented Jan 15, 2025

Hi Glen,
Yes, patience is required.
I will fix the Excel export later today. Thank you for reporting!!!

@glenmwright
Copy link

glenmwright commented Jan 15, 2025

After choosing abort on a failed merge, JWLManager does not close or crash, but the progress stays open. Is it possible to continue to the next merge task rather than fail? Perhaps presenting the failures at the end of the merge process?

image
image

@erykjj
Copy link
Owner Author

erykjj commented Jan 15, 2025

Hi @glenmwright ,

Both issues should be fixed in beta4. Please confirm.

But you raised an interesting question: should the merge proceed despite the error? Personally, I think that it should terminate. You don't want to merge a damaged archive and you know you won't have a complete merge.

On the other hand, it may be a way to "rescue" the good stuff from a corrupted archive ??

Open to opinions, please.

@glenmwright
Copy link

While there are some clues in the Abort box, I am not sure I would be able to find the error to make the merge work. I can see it is a highlight in the Isaiah Book 1. Fortunately, you have already give us superb tools to export, delete, and import to "rescue" the good stuff.

@glenmwright
Copy link

glenmwright commented Jan 15, 2025

All exporting and importing is working in Beta4.

Notice where the merge crashes with my Highlights file
image

@erykjj
Copy link
Owner Author

erykjj commented Jan 15, 2025

@glenmwright

That's a very interesting export... You'll notice the entries starting with your highlighted one are missing A) Bible book and chapter number (first two "None" fields) AND B) DocumentId (third "None" field). The highlight has to be placed in either a Bible verse or a publication paragraph. In this case, we've got the paragraph number (second number from the left), but we haven't got the DocumentId that would identify the article/chapter in the ip-1 book.

So, the question arises, how did you get those entries there?
Please try the "Reindex" option in the "Utilities" menu, then export again and see if they're still there.

@erykjj
Copy link
Owner Author

erykjj commented Jan 19, 2025

I can test on iOS, iPadOS, and macOS (Apple Silicon)

Hi @skybird-dev !
Any feedback from the Apple side?

@AnatolyOn
Copy link

AnatolyOn commented Jan 21, 2025

Small bug in v 7.0.0 beta 4.

When you open a new archive, the statistics are not updated after loading, they are updated only after changing the category, although in version 6.12 this works correctly.

Image

Image

@erykjj
Copy link
Owner Author

erykjj commented Jan 21, 2025

When you open a new archive, the statistics are not updated after loading, they are updated only after changing the category, although in version 6.12 this works correctly.

Thank you, @AnatolyOn , for your report! This was confirmed and fixed. I had been using drag-and-drop to open files and neglected to check how opening via the menu was affecte by the recent changes. Good job!

@erykjj
Copy link
Owner Author

erykjj commented Jan 23, 2025

@skybird-dev @AnatolyOn @glenmwright

Any other unusual behavior or "anomalies" observed in your testing?

@AnatolyOn
Copy link

Yes. Notes gone after reindexing

Before total -130

Image

After - 109

Image

@erykjj
Copy link
Owner Author

erykjj commented Jan 23, 2025

Notes gone after reindexing

@AnatolyOn
Were those notes blank (blank title and body)?
If not, could you please "Mask" (Utilities menu) the original (130 items) and send me that?

@AnatolyOn
Copy link

merged1737491777.zip

@erykjj
Copy link
Owner Author

erykjj commented Jan 23, 2025

@AnatolyOn

Thank you. It's as I suspected: these are empty notes that are being removed (21 of them).

Image

That is by design: notes that have a blank title and an empty note body are removed to "clean up" the database. The solution: if you want them there as some kind of "bookmark", add something to either the title and/or body.

@erykjj
Copy link
Owner Author

erykjj commented Jan 23, 2025

v7.0.0-beta5 is out with some important fixes.

Thank you all!

@glenmwright
Copy link

Eryk,

Beta 5 and your keen eye solved all my issues. I dragged a playlist in and it imported successfully. I will continue testing.

@glenmwright
Copy link

I discovered something a couple times and I thought it was just me. This seems to be an issue with v6.1.2 as well.

  1. Export some notes
  2. Import those notes
  3. Save the backup file
  4. With the same file backup still open, export another set of notes.
  5. The Save dialog box appears, give the file a name and choose Save. No export file is saved. The status bar does not say notes have been exported.

@erykjj
Copy link
Owner Author

erykjj commented Jan 24, 2025

Thank you again, @glenmwright !
Confirmed and fixed. A little typo on my part. Nice catch!

@erykjj
Copy link
Owner Author

erykjj commented Jan 27, 2025

I just pushed out v7.0.0-beta6, hopefully the last one before the official release.

Please report any anomalities you may spot, especially with exporting, importing and merging.

Thank you!

@glenmwright
Copy link

glenmwright commented Jan 27, 2025

The other day when you suggested I re-index, I noticed that I lost all my Tags. I tried it with a few different archives and it does the same. The same happens in version 6.1.2

Steps to reproduce:

  1. Create a new archive
  2. Import a file with tags
  3. Choose Re-index
  4. Tags are removed.

Image

@erykjj
Copy link
Owner Author

erykjj commented Jan 27, 2025

Wow, @glenmwright , that's pretty bad :-|

I import notes into my archive and reindex on a weekly basis, and have never lost tags, but I have confirmed that it does happen with your steps...

It may have to do with it being a new archive?? I will investigate.

Hope you are testing with non-official backups.

@glenmwright
Copy link

I have tried it with a few of my backups and the tags are deleted in each one. This hasn't always been the case because I remember it working in the past. I am always careful and keep multiple backups of my backups and you have made it easier for us to restore in case of an emergency.

@erykjj
Copy link
Owner Author

erykjj commented Jan 28, 2025

I found the bug. It was introduced at some point after the Playlist feature was added... as part of the Playlist-related tables being reindexed.

Glen, I really appreciate your input/colaboration!

@erykjj
Copy link
Owner Author

erykjj commented Jan 28, 2025

v7.0.0-beta7 is out with a fix

@erykjj
Copy link
Owner Author

erykjj commented Jan 28, 2025

@glenmwright
Please confirm it works now, and I will release official tomorrow - in view of that bug being rather serious :-\

@glenmwright
Copy link

Excellent my tags stayed, re-indexing with a new archive and my backup files work as they should.

@erykjj
Copy link
Owner Author

erykjj commented Jan 28, 2025

Closing this as v7.0.0 is now released. Please submit regular issues if you find further anomalies.

@erykjj erykjj closed this as completed Jan 28, 2025
@Reulym
Copy link

Reulym commented Feb 1, 2025

I am available to help and learn. Portuguese language (Brazil)

@erykjj
Copy link
Owner Author

erykjj commented Feb 2, 2025

I am available to help and learn. Portuguese language (Brazil)

Hi @Reulym , thank you for your offer. Please feel free to report any issues you may find while using the app. Portuguese is an option in the View > Language menu. You can double-check the translations as you use it :-)

@erykjj erykjj unpinned this issue Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants