Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta-testers needed #205

Open
erykjj opened this issue Jan 6, 2025 · 13 comments
Open

Beta-testers needed #205

erykjj opened this issue Jan 6, 2025 · 13 comments
Assignees

Comments

@erykjj
Copy link
Owner

erykjj commented Jan 6, 2025

Please let me know if you are able to collaborate by doing some beta-testing. This will include trying out new functionality and doing all kinds of things to try to break the app, and reporting the results.

I will need to know what OS you can test on.

@erykjj erykjj pinned this issue Jan 6, 2025
@glenmwright
Copy link

Hi Eryk, I am always happy to test on Windows.

@erykjj
Copy link
Owner Author

erykjj commented Jan 10, 2025

https://github.com/erykjj/jwlmanager/releases/tag/v7.0.0-beta1

I have implemented direct merge of two archives: just drag-and-drop a second one into the app while you have one opened and you will have the option to open it or merge it into the first (over-writing any at the same location and with the same title).

As a result, I have adjusted some of the export and import functions (and fixed some minor issues).

I need systematic testing of exporting and importing all the different categories (Notes, Highlights, Annotations, Bookmarks, Favorites).

Please focus on one category at a time, and just one or two items, to ensure that the resulting archive is as expected.

Thank you!

@erykjj
Copy link
Owner Author

erykjj commented Jan 11, 2025

v7.0.0-beta2

  • Full merge of all items (including Playlists)

@skybird-dev
Copy link

I can test on iOS, iPadOS, and macOS (Apple Silicon)

@erykjj
Copy link
Owner Author

erykjj commented Jan 12, 2025

Hi @skybird-dev

Thank you! Please grab the latest v7 beta from here: https://github.com/erykjj/jwlmanager/releases

I can't build for iOS, but there is a macOS build.

Thanks again!

@glenmwright
Copy link

Good morning,

I have done some small file merging and it is working. Working with larger files seems to hang at 40%, or perhaps I am not patient enough to wait. I have learned that when I kill the task, I have to delete the lock file for the program to start again.

However, the Export to Excel is failing in 7.0 but works in 6.1.2.

JWLManager v7.0.0
Windows-10-10.0.19045-SP0

Traceback (most recent call last):
File "JWLManager.py", line 1418, in export_items
File "JWLManager.py", line 1202, in export_notes
File "JWLManager.py", line 930, in create_xlsx
NameError: cannot access free variable 'item_list' where it is not associated with a value in enclosing scope

@erykjj
Copy link
Owner Author

erykjj commented Jan 15, 2025

Hi Glen,
Yes, patience is required.
I will fix the Excel export later today. Thank you for reporting!!!

@glenmwright
Copy link

glenmwright commented Jan 15, 2025

After choosing abort on a failed merge, JWLManager does not close or crash, but the progress stays open. Is it possible to continue to the next merge task rather than fail? Perhaps presenting the failures at the end of the merge process?

image
image

@erykjj
Copy link
Owner Author

erykjj commented Jan 15, 2025

Hi @glenmwright ,

Both issues should be fixed in beta4. Please confirm.

But you raised an interesting question: should the merge proceed despite the error? Personally, I think that it should terminate. You don't want to merge a damaged archive and you know you won't have a complete merge.

On the other hand, it may be a way to "rescue" the good stuff from a corrupted archive ??

Open to opinions, please.

@glenmwright
Copy link

While there are some clues in the Abort box, I am not sure I would be able to find the error to make the merge work. I can see it is a highlight in the Isaiah Book 1. Fortunately, you have already give us superb tools to export, delete, and import to "rescue" the good stuff.

@glenmwright
Copy link

glenmwright commented Jan 15, 2025

All exporting and importing is working in Beta4.

Notice where the merge crashes with my Highlights file
image

@erykjj
Copy link
Owner Author

erykjj commented Jan 15, 2025

@glenmwright

That's a very interesting export... You'll notice the entries starting with your highlighted one are missing A) Bible book and chapter number (first two "None" fields) AND B) DocumentId (third "None" field). The highlight has to be placed in either a Bible verse or a publication paragraph. In this case, we've got the paragraph number (second number from the left), but we haven't got the DocumentId that would identify the article/chapter in the ip-1 book.

So, the question arises, how did you get those entries there?
Please try the "Reindex" option in the "Utilities" menu, then export again and see if they're still there.

@erykjj
Copy link
Owner Author

erykjj commented Jan 19, 2025

I can test on iOS, iPadOS, and macOS (Apple Silicon)

Hi @skybird-dev !
Any feedback from the Apple side?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants