Skip to content

Commit 9fbba1b

Browse files
committed
short case statements on same line
1 parent cc40114 commit 9fbba1b

21 files changed

+94
-204
lines changed

.clang-format

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
11
BasedOnStyle: Google
2+
AllowShortCaseLabelsOnASingleLine: true

.ycm_extra_conf.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
'-I' + str(home_dir) + '/eRPC/third_party',
4545
'-I' + str(home_dir) + '/eRPC/mica/src',
4646
'-I' + str(home_dir) + '/masstree-beta',
47-
'-isystem' + str(homedir) + '/dpdk/x86_64-native-linuxapp-gcc/include',
47+
'-isystem' + str(home_dir) + '/dpdk/x86_64-native-linuxapp-gcc/include',
4848
'-Wall',
4949
'-Werror',
5050
'-Wextra',

apps/smr/callbacks.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,8 @@ static int __raft_applylog(raft_server_t *, void *udata, raft_entry_t *ety,
3636

3737
size_t key_hash = mica::util::hash(&client_req->key, kAppKeySize);
3838
FixedTable *table = c->server.table;
39-
FixedTable::ft_key_t *ft_key = reinterpret_cast<FixedTable::ft_key_t *>(client_req->key);
39+
FixedTable::ft_key_t *ft_key =
40+
reinterpret_cast<FixedTable::ft_key_t *>(client_req->key);
4041

4142
auto result = table->set(key_hash, *ft_key,
4243
reinterpret_cast<char *>(&client_req->value));

apps/smr/smr.h

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -68,14 +68,9 @@ struct client_req_t {
6868
std::string to_string() const {
6969
std::ostringstream ret;
7070
ret << "[Key (";
71-
for (size_t k : key) {
72-
ret << std::to_string(k) << " ";
73-
}
74-
ret << "), Value (";
75-
for (size_t v : value) {
76-
ret << std::to_string(v) << " ";
77-
}
78-
ret << ")]";
71+
for (size_t k : key) ret << std::to_string(k) << "), ";
72+
ret << "Value (";
73+
for (size_t v : value) ret << std::to_string(v) << ")] ";
7974
return ret.str();
8075
}
8176
};
@@ -88,12 +83,10 @@ struct client_resp_t {
8883

8984
std::string to_string() const {
9085
switch (resp_type) {
91-
case ClientRespType::kSuccess:
92-
return "success";
86+
case ClientRespType::kSuccess: return "success";
9387
case ClientRespType::kFailRedirect:
9488
return "failed: redirect to node " + std::to_string(leader_node_id);
95-
case ClientRespType::kFailTryAgain:
96-
return "failed: try again";
89+
case ClientRespType::kFailTryAgain: return "failed: try again";
9790
}
9891
return "Invalid";
9992
}

apps/smr/time_entry.h

Lines changed: 6 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -28,24 +28,12 @@ class TimeEnt {
2828
std::string ret;
2929

3030
switch (type) {
31-
case TimeEntType::kClientReq:
32-
ret = "client_req";
33-
break;
34-
case TimeEntType::kSendAeReq:
35-
ret = "send_appendentries_req";
36-
break;
37-
case TimeEntType::kRecvAeReq:
38-
ret = "recv_appendentries_req";
39-
break;
40-
case TimeEntType::kSendAeResp:
41-
ret = "send_appendentries_resp";
42-
break;
43-
case TimeEntType::kRecvAeResp:
44-
ret = "recv_appendentries_resp";
45-
break;
46-
case TimeEntType::kCommitted:
47-
ret = "committed";
48-
break;
31+
case TimeEntType::kClientReq: ret = "client_req"; break;
32+
case TimeEntType::kSendAeReq: ret = "send_appendentries_req"; break;
33+
case TimeEntType::kRecvAeReq: ret = "recv_appendentries_req"; break;
34+
case TimeEntType::kSendAeResp: ret = "send_appendentries_resp"; break;
35+
case TimeEntType::kRecvAeResp: ret = "recv_appendentries_resp"; break;
36+
case TimeEntType::kCommitted: ret = "committed"; break;
4937
}
5038

5139
double usec = erpc::to_usec(tsc - base_tsc, freq_ghz);

src/pkthdr.h

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -34,14 +34,10 @@ enum PktType : uint64_t {
3434

3535
static std::string pkt_type_str(uint64_t pkt_type) {
3636
switch (pkt_type) {
37-
case kPktTypeReq:
38-
return "REQ";
39-
case kPktTypeRFR:
40-
return "RFR";
41-
case kPktTypeExplCR:
42-
return "CR";
43-
case kPktTypeResp:
44-
return "RESP";
37+
case kPktTypeReq: return "REQ";
38+
case kPktTypeRFR: return "RFR";
39+
case kPktTypeExplCR: return "CR";
40+
case kPktTypeResp: return "RESP";
4541
}
4642

4743
throw std::runtime_error("Invalid packet type.");

src/rpc_impl/rpc_pkt_loss.cc

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,7 @@ void Rpc<TTr>::pkt_loss_scan_st() {
4040
if (ms_elapsed > kSMTimeoutMs) send_sm_req_st(session);
4141
break;
4242
}
43-
default:
44-
break;
43+
default: break;
4544
}
4645
}
4746
}

src/rpc_impl/rpc_rx.cc

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,7 @@ void Rpc<TTr>::process_comps_st() {
5656
process_resp_one_st(sslot, pkthdr, rx_tsc);
5757
break;
5858
}
59-
case PktType::kPktTypeRFR:
60-
process_rfr_st(sslot, pkthdr);
61-
break;
59+
case PktType::kPktTypeRFR: process_rfr_st(sslot, pkthdr); break;
6260
case PktType::kPktTypeExplCR: {
6361
size_t rx_tsc = kCcOptBatchTsc ? batch_rx_tsc : dpath_rdtsc();
6462
process_expl_cr_st(sslot, pkthdr, rx_tsc);

src/rpc_impl/rpc_sm_api.cc

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,8 +137,7 @@ int Rpc<TTr>::destroy_session_st(int session_num) {
137137
LOG_WARN("%s: None. Session reset in progress.\n", issue_msg);
138138
return 0;
139139

140-
default:
141-
throw std::runtime_error("Invalid session state");
140+
default: throw std::runtime_error("Invalid session state");
142141
}
143142
}
144143

src/rpc_impl/rpc_sm_helpers.cc

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -14,20 +14,11 @@ void Rpc<TTr>::handle_sm_rx_st() {
1414
while (queue.size > 0) {
1515
const SmPkt sm_pkt = queue.unlocked_pop(); // Lock is held only briefly
1616
switch (sm_pkt.pkt_type) {
17-
case SmPktType::kConnectReq:
18-
handle_connect_req_st(sm_pkt);
19-
break;
20-
case SmPktType::kConnectResp:
21-
handle_connect_resp_st(sm_pkt);
22-
break;
23-
case SmPktType::kDisconnectReq:
24-
handle_disconnect_req_st(sm_pkt);
25-
break;
26-
case SmPktType::kDisconnectResp:
27-
handle_disconnect_resp_st(sm_pkt);
28-
break;
29-
default:
30-
throw std::runtime_error("Invalid packet type");
17+
case SmPktType::kConnectReq: handle_connect_req_st(sm_pkt); break;
18+
case SmPktType::kConnectResp: handle_connect_resp_st(sm_pkt); break;
19+
case SmPktType::kDisconnectReq: handle_disconnect_req_st(sm_pkt); break;
20+
case SmPktType::kDisconnectResp: handle_disconnect_resp_st(sm_pkt); break;
21+
default: throw std::runtime_error("Invalid packet type");
3122
}
3223
}
3324
}

0 commit comments

Comments
 (0)