New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runmany_wrap doesn't actually call the passed function #138

Closed

markan opened this issue Sep 15, 2018 · 0 comments

markan commented Sep 15, 2018 •

edited

Loading

I noticed that runmany_wrap doesn't actually call the function passed to it, it only returns it. Looks like some parens were dropped during the refactor (see https://github.com/erlware/erlware_commons/blob/master/src/ec_plists.erl#L878)

I think that's slipped through testing because the ec_plist map tests only test the default malt, which uses the local runmany local code path.

This seems straightforward, so I wrote a quick fix here: https://github.com/chef/erlware_commons/tree/ma/fix_for_ftmap. Happy to make it a PR if you like.

ariel-anieli added a commit to ariel-anieli/erlware_commons that referenced this issue


          Fix for erlware#138

378b885

ariel-anieli mentioned this issue

runmany_wrap/2 didn't call Fun: missing parens #163

Merged

ferd closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment