Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for review apps for site contributions #17

Closed
starbelly opened this issue Oct 21, 2020 · 1 comment
Closed

Add support for review apps for site contributions #17

starbelly opened this issue Oct 21, 2020 · 1 comment
Labels
need more info when a issue need more explanations

Comments

@starbelly
Copy link
Member

Currently if someone, including myself does a PR to the website there is no clear visibility into how the changes look, whether they work, etc. Instead it requires the reviewer to pull down the contributors branch, build assets, etc. etc. in order to effectively review a change.

We should use gigalixir (free tier surely) for spinning up review apps. This is relatively simple https://gigalixir.readthedocs.io/en/latest/deploy.html#how-to-set-up-review-apps-feature-branch-apps. Doing this in github actions is essentially the same, gigalixir made a howto using github actions but can't seem to find it ATM.

@benoitc benoitc added question Further information is requested need more info when a issue need more explanations and removed question Further information is requested labels Mar 15, 2021
@starbelly
Copy link
Member Author

Closing this in favor of erlef/website#317

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need more info when a issue need more explanations
Projects
None yet
Development

No branches or pull requests

2 participants