fixup! stdlib: reduce test log on gh

Author: u3s

lib/kernel/test/application_SUITE.erl

@@ -1382,8 +1382,8 @@ otp_3002(Conf) when is_list(Conf) ->
     %% Create the boot script
     {{KernelVer,StdlibVer}, {LatestDir, LatestName}} =
 	create_script_3002("script_3002"),
-    ct:pal(?HI_VERBOSITY, "LatestDir = ~p~n", [LatestDir]),
-    ct:pal(?HI_VERBOSITY, "LatestName = ~p~n", [LatestName]),
+    ct:log(?HI_VERBOSITY, "LatestDir = ~p~n", [LatestDir]),
+    ct:log(?HI_VERBOSITY, "LatestName = ~p~n", [LatestName]),
 
     case is_real_system(KernelVer, StdlibVer) of
 	      true ->
@@ -3214,7 +3214,7 @@ start_node_args(Name, Args) ->
 
 start_node_boot_3002(Name, Boot) ->
     Pa = filename:dirname(code:which(?MODULE)),
-    ct:pal(?HI_VERBOSITY, "start_node_boot ~p~n",
+    ct:log(?HI_VERBOSITY, "start_node_boot ~p~n",
 	   [" -pa " ++ Pa ++ " -env ERL_CRASH_DUMP erl_crash_dump." ++
 		atom_to_list(Name) ++ " -boot " ++ Boot ++
 		" -sasl dummy \"missing "]),
@@ -3230,7 +3230,7 @@ start_node_boot_config(Name, SysConfigFun, Conf, Boot) ->
 
 start_node_boot(Name, Config, Boot) ->
     Pa = filename:dirname(code:which(?MODULE)),
-    ct:pal(?HI_VERBOSITY,
+    ct:log(?HI_VERBOSITY,
 	   "start_node_boot ~p~n",[" -pa " ++ Pa ++ " -config " ++ Config ++
 				       " -boot " ++ atom_to_list(Boot)]),
     test_server:start_node(Name, slave,

lib/kernel/test/disk_log_SUITE.erl

@@ -1062,13 +1062,13 @@ mk_bytes(N) when N > 4 ->
     end.
 
 get_list(File, Log) ->
-    ct:pal(?HI_VERBOSITY, "File ~p~n", [File]),
+    ct:log(?HI_VERBOSITY, "File ~p~n", [File]),
     ok = disk_log:sync(Log),
     {ok, B} = file:read_file(File),
     binary_to_list(B).
 
 get_list(File, Log, rotate) ->
-    ct:pal(?HI_VERBOSITY, "File ~p~n", [File]),
+    ct:log(?HI_VERBOSITY, "File ~p~n", [File]),
     ok = disk_log:sync(Log),
     DFile = filename:rootname(File,".gz"),
     decompress_file(File, DFile),

lib/kernel/test/erl_distribution_SUITE.erl

@@ -1062,7 +1062,7 @@ hidden_node(DCfg, Config) ->
     ok.
 
 hidden_node(DCfg, HArgs, _Config) ->
-    ct:pal("--- Hidden argument(s): ~s~n", [HArgs]),
+    ct:log("--- Hidden argument(s): ~s~n", [HArgs]),
     {ok, V} = start_node(DCfg, visible_node),
     VMN = start_monitor_nodes_proc(V),
     {ok, H} = start_node(DCfg, hidden_node, HArgs),
@@ -1488,8 +1488,8 @@ monitor_nodes_misc(DCfg, _Config) ->
     {N1, #{connection_id := N1CId}} = lists:keyfind(N1, 1, NodesInfo),
     {N2, #{connection_id := N2CId}} = lists:keyfind(N2, 1, NodesInfo),
 
-    ct:pal("N1: ~p ~p~n", [N1, N1CId]),
-    ct:pal("N2: ~p ~p~n", [N2, N2CId]),
+    ct:log("N1: ~p ~p~n", [N1, N1CId]),
+    ct:log("N2: ~p ~p~n", [N2, N2CId]),
 
     receive {nodeup, N1, #{node_type := visible, connection_id := N1CId}} -> ok end,
     receive {nodeup, N2, #{node_type := hidden, connection_id := N2CId}} -> ok end,

lib/kernel/test/file_SUITE.erl

@@ -4828,10 +4828,10 @@ run_large_file_test(Config, Run, Name) ->
                     {skip, "Failed to query disk space for priv_dir. "
                            "Is it on a remote file system?~n"};
                 N when N >= 5 * (1 bsl 20) ->
-                    ct:pal("Free disk: ~w KByte~n", [N]),
+                    ct:log("Free disk: ~w KByte~n", [N]),
                     do_run_large_file_test(Config, Run, Name);
                 N when N < 5 * (1 bsl 20) ->
-                    ct:pal("Free disk: ~w KByte~n", [N]),
+                    ct:log("Free disk: ~w KByte~n", [N]),
                     {skip,"Less than 5 GByte free"}
             end;
 	_ ->

lib/kernel/test/gen_tcp_echo_SUITE.erl

@@ -245,7 +245,7 @@ echo_packet(Config, SockOpts, EchoFun, EchoOpts) ->
     {ok, Echo} =
         kernel_test_lib:connect(Config, localhost, EchoPort, SockOpts),
 
-    ct:pal("Echo socket: ~w", [Echo]),
+    ct:log("Echo socket: ~w", [Echo]),
 
     SlowEcho = lists:member(slow_echo, EchoOpts),
 

lib/kernel/test/gen_tcp_misc_SUITE.erl

@@ -8087,7 +8087,7 @@ otp_13939(Config) when is_list(Config) ->
             timer:sleep(100),
 
             {error, Code} = gen_tcp:send(Accepted, <<0:(10*1024*1024*8)>>),
-            ct:pal("gen_tcp:send returned ~p~n", [Code])
+            ct:log("gen_tcp:send returned ~p~n", [Code])
         end, [link, monitor]),
 
     receive

lib/kernel/test/gen_tcp_socket_SUITE.erl

@@ -79,7 +79,7 @@ testcases(direct) ->
 init_per_suite(Config) ->
     case socket:is_supported(protocols, tcp) of
         true ->
-            ct:pal("socket:info():~n    ~p~n", [socket:info()]),
+            ct:log("socket:info():~n    ~p~n", [socket:info()]),
             {ok, BindAddr} = kernel_test_lib:which_local_addr(?DOMAIN),
             [{bind_addr, #{ family => ?DOMAIN, addr   => BindAddr }}
             | Config];
@@ -88,7 +88,7 @@ init_per_suite(Config) ->
     end.
 
 end_per_suite(_Config) ->
-    ct:pal("socket:info():~n    ~p~n", [socket:info()]),
+    ct:log("socket:info():~n    ~p~n", [socket:info()]),
     ok.
 
 
@@ -140,7 +140,7 @@ init_per_group_size(K, Adj, Config) ->
      %%
     {MeanSize, SizeSuffix} = size_and_suffix(1 bsl K),
     {PacketCount, CountSuffix} = size_and_suffix(N),
-    ct:pal("Packet mean size: ~w ~sByte, packet count: ~w ~s",
+    ct:log("Packet mean size: ~w ~sByte, packet count: ~w ~s",
            [MeanSize, SizeSuffix, PacketCount, CountSuffix]),
     %%
     [{testdata_server, StopTag},
@@ -262,15 +262,15 @@ run_xfer(
                       send_loop(A, Iovecs),
                       ok = gen_tcp:close(A)
                   catch Class : Reason : Stacktrace ->
-                          ct:pal(
+                          ct:log(
                             "Sender crash [~w] ~w : ~p~n    ~p~n",
                             [self(), Class, Reason, Stacktrace]),
                           erlang:raise(Class, Reason, Stacktrace)
                   end
           end, [monitor]),
     receive
         {Tag, Sockaddr} ->
-            ct:pal("try connect to ~p"
+            ct:log("try connect to ~p"
                    "~n   TC:      ~p"
                    "~n", [Sockaddr, TC]),
             C = case connect(Params, Sockaddr, TC) of
@@ -288,7 +288,7 @@ run_xfer(
                 T = erlang:convert_time_unit(T2 - T1, native, millisecond),
                 report_MByte_s(Params, TC, TotalSize, T)
             catch Class : Reason : Stacktrace ->
-                    ct:pal(
+                    ct:log(
                       "Receiver crash [~w] ~w : ~p~n    ~p~n",
                       [self(), Class, Reason, Stacktrace]),
                     exit(Sender, receiver_crash),
@@ -697,7 +697,7 @@ recv_loop_active_n(S, Sizes, M, N) ->
 %% -------
 
 report(Name, Value, Suffix) ->
-    ct:pal("### ~s: ~w ~s", [Name, Value, Suffix]),
+    ct:log("### ~s: ~w ~s", [Name, Value, Suffix]),
     ct_event:notify(
       #event{
          name = benchmark_data,

lib/kernel/test/global_SUITE.erl

@@ -1678,7 +1678,7 @@ loop_it(N, Config) -> loop_it(N,N, Config).
 
 loop_it(0,_, _Config) -> ok;
 loop_it(N,M, Config) ->
-    ct:pal(?HI_VERBOSITY, "Round: ~w", [M-N]),
+    ct:log(?HI_VERBOSITY, "Round: ~w", [M-N]),
     ring(Config),
     line(Config),
     loop_it(N-1,M, Config).
@@ -3482,7 +3482,7 @@ global_groups_change(Config) ->
 	Info1ok ->
 	    ok;
 	_ ->
-            ct:pal("Expected: ~p~n"
+            ct:log("Expected: ~p~n"
                    "Got     : ~p~n",
                    [Info1ok, Info1]),
 	    ct:fail({{"could not change the global groups"
@@ -3493,7 +3493,7 @@ global_groups_change(Config) ->
 	Info2ok ->
 	    ok;
 	_ ->
-            ct:pal("Expected: ~p~n"
+            ct:log("Expected: ~p~n"
                    "Got     : ~p~n",
                    [Info2ok, Info2]),
 	    ct:fail({{"could not change the global groups"
@@ -3504,7 +3504,7 @@ global_groups_change(Config) ->
 	Info3ok ->
 	    ok;
 	_ ->
-            ct:pal("Expected: ~p~n"
+            ct:log("Expected: ~p~n"
                    "Got     : ~p~n",
                    [Info3ok, Info3]),
 	    ct:fail({{"could not change the global groups"
@@ -3515,7 +3515,7 @@ global_groups_change(Config) ->
 	InfoAok ->
 	    ok;
 	_ ->
-            ct:pal("Expected: ~p~n"
+            ct:log("Expected: ~p~n"
                    "Got     : ~p~n",
                    [InfoAok, InfoA]),
 	    ct:fail({{"could not change the global groups"
@@ -3526,7 +3526,7 @@ global_groups_change(Config) ->
 	InfoBok ->
 	    ok;
 	_ ->
-            ct:pal("Expected: ~p~n"
+            ct:log("Expected: ~p~n"
                    "Got     : ~p~n",
                    [InfoBok, InfoB]),
 	    ct:fail({{"could not change the global groups"
@@ -3538,7 +3538,7 @@ global_groups_change(Config) ->
 	InfoCok ->
 	    ok;
 	_ ->
-            ct:pal("Expected: ~p~n"
+            ct:log("Expected: ~p~n"
                    "Got     : ~p~n",
                    [InfoCok, InfoC]),
 	    ct:fail({{"could not change the global groups"
@@ -3549,7 +3549,7 @@ global_groups_change(Config) ->
 	InfoDok ->
 	    ok;
 	_ ->
-            ct:pal("Expected: ~p~n"
+            ct:log("Expected: ~p~n"
                    "Got     : ~p~n",
                    [InfoDok, InfoD]),
 	    ct:fail({{"could not change the global groups"
@@ -3560,7 +3560,7 @@ global_groups_change(Config) ->
 	InfoEok ->
 	    ok;
 	_ ->
-            ct:pal("Expected: ~p~n"
+            ct:log("Expected: ~p~n"
                    "Got     : ~p~n",
                    [InfoEok, InfoE]),
 	    ct:fail({{"could not change the global groups"
@@ -3588,7 +3588,7 @@ gg_wait(Node, Synced, SyncError, NoContact) ->
     receive after 100 -> ok end,
     try
         GGInfo = rpc:call(Node, global_group, info, []),
-        ct:pal("GG info: ~p~n", [GGInfo]),
+        ct:log("GG info: ~p~n", [GGInfo]),
         case proplists:lookup(synced_nodes, GGInfo) of
             {synced_nodes, Synced} -> ok;
             _ -> throw(wait)
@@ -3903,7 +3903,7 @@ pr_diff(Str, T0, T1) ->
 	       {_, {H,M,S}} = calendar:time_difference(T0, T1),
 	       ((H*60+M)*60)+S
 	   end,
-    ct:pal(?HI_VERBOSITY,"~13s: ~w (diff: ~w)",[Str, T1, Diff]),
+    ct:log(?HI_VERBOSITY,"~13s: ~w (diff: ~w)",[Str, T1, Diff]),
     if
 	Diff > 100 ->
 	    io:format(1,"~s: ** LARGE DIFF ~w~n", [Str, Diff]);
@@ -4922,7 +4922,7 @@ node_tracker_loop(Nodes) ->
                           stopped ->
                               ok;
                           alive ->
-                              ct:pal("WARNING: The node ~p was not "
+                              ct:log("WARNING: The node ~p was not "
                                      "stopped by the test case!", [N])
                       end,
                       %% We try to kill every node, even those reported as
@@ -4931,13 +4931,13 @@ node_tracker_loop(Nodes) ->
                           {badrpc,nodedown} ->
                               ok;
                           {badrpc,timeout} ->
-                              ct:pal("WARNING: Failed to kill node: ~p~n"
+                              ct:log("WARNING: Failed to kill node: ~p~n"
                                      "         Disconnecting it, but it may "
                                      "still be alive!", [N]),
                               erlang:disconnect_node(N),
                               ok;
                           Unexpected ->
-                              ct:pal("WARNING: Failed to kill node: ~p~n"
+                              ct:log("WARNING: Failed to kill node: ~p~n"
                                      "         Got response: ~p~n"
                                      "         Disconnecting it, but it may "
                                      "still be alive!", [N, Unexpected]),
@@ -4976,7 +4976,7 @@ stop_node_tracker(Config) ->
                     NTFailure;
                 _ ->
                     %% Don't fail due to node tracker...
-                    ct:pal("WARNING: Node tracker failure: ~p", [NTFailure]),
+                    ct:log("WARNING: Node tracker failure: ~p", [NTFailure]),
                     ok
             end
     end.