Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define Ratio(Complex) type #218

Open
6 tasks
GreasySlug opened this issue Oct 23, 2022 · 1 comment · May be fixed by #423
Open
6 tasks

Define Ratio(Complex) type #218

GreasySlug opened this issue Oct 23, 2022 · 1 comment · May be fixed by #423
Labels
enhancement New feature or request

Comments

@GreasySlug
Copy link
Member

GreasySlug commented Oct 23, 2022 •
edited

  • Ratio and Complex Type
    • Create ratio.rs module on erg_common
      • Create fraction instead of float
    • Create complex by using ratio.rs
    • Add Ratio and Complex type to ValueObj
    • Define the ratio again in _erg_prelude_std.py using Python's fraction module
@GreasySlug GreasySlug added the enhancement New feature or request label Oct 23, 2022
@GreasySlug GreasySlug changed the title Define fraction for Ratio(Complex) type Define Ratio(Complex) type Oct 23, 2022
@GreasySlug
Copy link
Member Author

#215

@GreasySlug GreasySlug pinned this issue Oct 23, 2022
@GreasySlug GreasySlug unpinned this issue Oct 23, 2022
@GreasySlug GreasySlug linked a pull request Apr 27, 2023 that will close this issue
Draft
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Add Ratio(Complex) type GreasySlug/erg
1 participant
@GreasySlug