Skip to content

Commit 9d53aa1

Browse files
feat: Update expand filter button (#640)
Update expand filter button to make it clear that there are more filters than the quick
1 parent d80012c commit 9d53aa1

File tree

5 files changed

+34
-10
lines changed

5 files changed

+34
-10
lines changed

packages/filter/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@equinor/workspace-filter",
3-
"version": "4.0.3",
3+
"version": "4.0.4",
44
"type": "module",
55
"sideEffects": false,
66
"license": "MIT",

packages/filter/src/lib/components/quickFilter/QuickFilter.tsx

Lines changed: 21 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,13 @@ import { FilterQuickSearch } from '../filterQuickSearch/FilterQuickSearch';
1212
import { FiltersAppliedInfo } from '../filtersAppliedInfo/FiltersAppliedInfo';
1313
import { FilterGroup as IFilterGroup } from '../../types';
1414
import { useFilterContext } from '../../context/filterContext';
15-
import { StyledButton } from '../toggleHideFilterPopover/toggleHideFilterPopover.styles';
15+
import { StyledButton, StyledButtonContent } from '../toggleHideFilterPopover/toggleHideFilterPopover.styles';
1616
import { FilterClearIcon, FilterCollapseIcon, FilterExpandIcon } from '../../icons';
1717
import { ToggleHideFilterPopover } from '../toggleHideFilterPopover/ToggleHideFilterPopover';
1818
import { FilterView } from '../filterView/FilterView';
1919
import { useFilterStyles } from '../../hooks/useFilterStyles';
2020
import { FilterLoadingFallback } from '../Filter';
21+
import { Button, Tooltip } from '@equinor/eds-core-react';
2122

2223
/**
2324
* How to separate controller and visual logic in this component?
@@ -111,13 +112,25 @@ const QuickFilterReady = ({ groups }: QuickFilterReadyProps) => {
111112
<FiltersAppliedInfo activeFilters={calculateHiddenFiltersApplied()} />
112113
{isFilterExpanded && <ToggleHideFilterPopover allFilters={allFilterGroups} setFilterOrder={setFilterOrder} />}
113114

114-
<StyledButton onClick={() => clearActiveFilters()}>
115-
<FilterClearIcon isDisabled={uncheckedValues.map((s) => s.values).flat().length === 0} />
116-
</StyledButton>
117-
118-
<StyledButton onClick={toggleFilterIsExpanded}>
119-
{isFilterExpanded ? <FilterCollapseIcon /> : <FilterExpandIcon />}
120-
</StyledButton>
115+
<Tooltip title="Clear all active filters">
116+
<StyledButton onClick={() => clearActiveFilters()}>
117+
<FilterClearIcon isDisabled={uncheckedValues.map((s) => s.values).flat().length === 0} />
118+
</StyledButton>
119+
</Tooltip>
120+
121+
<Tooltip title={isFilterExpanded ? 'Hide all filter options' : 'Show all filter options'}>
122+
<Button variant="ghost" onClick={toggleFilterIsExpanded}>
123+
{isFilterExpanded ? (
124+
<StyledButtonContent>
125+
<FilterCollapseIcon /> <div>Hide all</div>
126+
</StyledButtonContent>
127+
) : (
128+
<StyledButtonContent>
129+
<FilterExpandIcon /> <div>Show all</div>
130+
</StyledButtonContent>
131+
)}
132+
</Button>
133+
</Tooltip>
121134
</StyledButtonWrapper>
122135
</StyledCompactFilterWrapper>
123136
{isFilterExpanded && (

packages/filter/src/lib/components/quickFilter/quickFilter.styles.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ export const StyledCompactFilterWrapper = styled.div<{ isExpanded: boolean }>`
1111
height: 48px;
1212
width: 100%;
1313
background-color: ${tokens.colors.ui.background__light.hex};
14+
padding: 0 6px;
15+
box-sizing: border-box;
1416
`;
1517

1618
export const StyledQuickFilterGroupsLayout = styled.div`
@@ -36,4 +38,5 @@ export const StyledButtonWrapper = styled.div`
3638
align-items: center;
3739
justify-content: flex-end;
3840
background-color: ${tokens.colors.ui.background__light.hex};
41+
gap: 10px;
3942
`;

packages/filter/src/lib/components/toggleHideFilterPopover/toggleHideFilterPopover.styles.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,3 +27,11 @@ export const StyledButton = styled.button`
2727
align-items: center;
2828
text-align: center;
2929
`;
30+
31+
export const StyledButtonContent = styled.div`
32+
display: flex;
33+
justify-content: space-between;
34+
align-items: center;
35+
width: 80px;
36+
white-space: nowrap;
37+
`;

packages/workspace-fusion/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@equinor/workspace-fusion",
3-
"version": "9.0.11",
3+
"version": "9.0.12",
44
"type": "module",
55
"sideEffects": false,
66
"license": "MIT",

0 commit comments

Comments
 (0)