Skip to content

Commit 0913d8c

Browse files
fix: filter sort order (#522)
* Remove min width so search icon and text doesnt overlap * Bump versions * feat: ✨ ag grid cell selection * Prettified Code! * fix filter sort order * chore: bump workspace * fix: 🐛 detailSidesheet overshadowing create sidesheet --------- Co-authored-by: idrisbo <[email protected]> Co-authored-by: Gustav-Eikaas <[email protected]>
1 parent 6d2bd6e commit 0913d8c

File tree

5 files changed

+19
-11
lines changed

5 files changed

+19
-11
lines changed

packages/filter/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@equinor/workspace-filter",
3-
"version": "3.0.0",
3+
"version": "3.0.1",
44
"type": "module",
55
"sideEffects": false,
66
"license": "MIT",

packages/filter/src/lib/components/quickFilter/QuickFilter.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,10 @@ const QuickFilterReady = ({ groups }: QuickFilterReadyProps) => {
129129
</StyledSearchLine>
130130
</StyledCompactFilterWrapper>
131131
{isFilterExpanded && (
132-
<FilterView isFetching={query.isFetching} groups={groups.filter((s) => visibleFilterGroups.includes(s.name))} />
132+
<FilterView
133+
isFetching={query.isFetching}
134+
groups={visibleFilterGroups.map((x) => groups.find((s) => s.name === x)).filter(Boolean) as IFilterGroup[]}
135+
/>
133136
)}
134137
</StyledWrapper>
135138
);

packages/filter/src/lib/components/toggleHideFilterPopover/ToggleHideFilterPopover.tsx

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import { Icon, Checkbox, Popover } from '@equinor/eds-core-react';
22
import { tokens } from '@equinor/eds-tokens';
33
import { useState, useRef } from 'react';
44
import { ReactSortable } from 'react-sortablejs';
5-
import { SortObject } from '../../types/sortObject';
65
import { StyledButton, StyledItemWrapper, StyledPopoverList } from './toggleHideFilterPopover.styles';
76

87
interface ShowHideFilterButtonProps {
@@ -19,18 +18,19 @@ export const ToggleHideFilterPopover = ({
1918
const [isOpen, setIsOpen] = useState(false);
2019
const ref = useRef<HTMLDivElement>(null);
2120

22-
const [list, setList] = useState<SortObject<string>[]>(allFilters.map((s) => ({ id: s, item: s })));
21+
const listRef = useRef(allFilters.map((s) => ({ id: s, item: s })));
2322

2423
const handleChange = (val: string) => {
2524
if (visibleFilters.includes(val)) {
26-
setVisibleFilters(visibleFilters.filter((s) => s !== val));
25+
setVisibleFilters([...visibleFilters.filter((s) => s !== val)]);
2726
} else {
2827
setVisibleFilters([...visibleFilters, val]);
2928
}
3029
};
3130
const DraggableHandleSelector = 'globalDraggableHandle';
3231

33-
const updateList = () => setVisibleFilters(list.map((s) => s.item).filter((s) => visibleFilters.includes(s)));
32+
const updateList = () =>
33+
setVisibleFilters(listRef.current.map((s) => s.item).filter((s) => visibleFilters.includes(s)));
3434

3535
return (
3636
<>
@@ -51,11 +51,13 @@ export const ToggleHideFilterPopover = ({
5151
<ReactSortable
5252
animation={200}
5353
handle={`.${DraggableHandleSelector}`}
54-
list={list}
55-
setList={setList}
54+
list={listRef.current}
55+
setList={(e) => {
56+
listRef.current = e;
57+
}}
5658
onEnd={updateList}
5759
>
58-
{list.map(({ item }) => (
60+
{listRef.current.map(({ item }) => (
5961
<StyledItemWrapper className={DraggableHandleSelector} key={item}>
6062
<Checkbox
6163
size={2}

packages/workspace-fusion/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@equinor/workspace-fusion",
3-
"version": "6.0.1",
3+
"version": "6.0.2",
44
"type": "module",
55
"sideEffects": false,
66
"license": "MIT",

packages/workspace-fusion/src/lib/context/WorkspaceControllerContext.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,10 @@ export function WorkspaceContextProvider<T>(props: WorkspaceContextProviderProps
2121
handleTabChange,
2222
updatePayload,
2323
isCreateSidesheetOpen,
24-
openCreateSidesheet: () => setCreateSidesheetOpen(true),
24+
openCreateSidesheet: () => {
25+
clearSelection();
26+
setCreateSidesheetOpen(true);
27+
},
2528
closeCreateSidesheet: () => setCreateSidesheetOpen(false),
2629
clearSelection,
2730
selectById,

0 commit comments

Comments
 (0)