Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disconnect bookmark api client from service module #796

Open
odinr opened this issue Apr 20, 2023 · 1 comment
Open

Disconnect bookmark api client from service module #796

odinr opened this issue Apr 20, 2023 · 1 comment
Labels
✨ improvement 🤷 question Further information is requested

Comments

@odinr
Copy link
Collaborator

odinr commented Apr 20, 2023

packages/modules/bookmark/src/client/bookmarkClient.ts

the api client should only use function from config.
by default the configurator wires up the link to services module.

Create a interface for the Api Client that will be consumed in the bookmark client
@odinr odinr added ✨ improvement 🤷 question Further information is requested labels Apr 20, 2023
@odinr odinr mentioned this issue Apr 20, 2023
Merged
@Noggling
Copy link
Collaborator

It more wrappers upon wrappers but I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
✨ improvement 🤷 question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@odinr @Noggling