The instance of entity type 'Installation' cannot be tracked because another instance with the same key value for {'Id'} is already being tracked

[tsundvoll]

Describe the bug
Got a 500 error when trying to delete an InspectionArea with Swagger

To Reproduce
Steps to reproduce the behavior:

1. call DELETE inspectionAreas/{id} in Swagger for an existing inspectionArea ID
2. observe that the error message in the Flotilla backend is:
   System.InvalidOperationException: The instance of entity type 'Installation' cannot be tracked because another instance with the same key value for {'Id'} is already being tracked. When attaching existing entities, ensure that only one entity instance with a given key value is attached. Consider using 'DbContextOptionsBuilder.EnableSensitiveDataLogging' to see the conflicting key values.

Expected behavior
The inspectionArea should have been deleted

[andchiind]

Which environment was this in? Was it locally?

[andchiind]

The issue seems to be that InspectionArea is included in the MissionDefinition and MissionRun models, where they are not optional. So we cannot just delete an InspectionArea entry since that would make the other tables inconsistent. One solution could be to have a "IsDeprecated" flag in the InspectionArea model which we can use to filter them away, but personally I think it might be best to just not delete InspectionAreas. In the rare case where it's needed to could just do it manually with SQL. So maybe this issue should be about removing that endpoint?

[tsundvoll]

Good point.

Let's solve this by introducing a deprecated field for the inspection areas,

Then the DELETE endpoint can be removed

[andchiind]

We could also use the DELETE endpoint to set the deprecation flag? It should appear equivalent to the user anyways.