Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support Object.create(null) #111

Open
jiangjiyun opened this issue May 21, 2021 · 2 comments · May be fixed by #134
Open

add support Object.create(null) #111

jiangjiyun opened this issue May 21, 2021 · 2 comments · May be fixed by #134

Comments

@jiangjiyun
Copy link

Object.create(null).valueOf === undefined

if (a.valueOf !== Object.prototype.valueOf) return a.valueOf() === b.valueOf();

error: a.valueOf is not a function
@FrankHassanabad FrankHassanabad mentioned this issue Jun 4, 2021
Merged
5 tasks
@LeeeeeeM
Copy link

how's the progress

@shiiiiiiji shiiiiiiji linked a pull request Aug 5, 2022 that will close this issue
Open
@zhangpanweb zhangpanweb mentioned this issue Aug 13, 2022
Open
@mrhether
Copy link

Any update here can we merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bugfix: objects without valueOf and toString function do not throw error shiiiiiiji/fast-deep-equal
3 participants
@mrhether @jiangjiyun @LeeeeeeM