Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimum data.table #976

Open
sbfnk opened this issue Nov 5, 2024 · 3 comments
Open

minimum data.table #976

sbfnk opened this issue Nov 5, 2024 · 3 comments

Comments

@sbfnk
Copy link
Contributor

sbfnk commented Nov 5, 2024

turns out this line in the new non-randomised PIT

f_bar <- function(u) {

relies on a fairly cutting-edge data.table version (1.16.0, released 25 August 2024) that supports a vector for default

We either have to require this version as a minimum or change the code.

@nikosbosse
Copy link
Contributor

does that data.table version have any relevant dependencies? If not then I don't mind either way (maybe very slight preference for not requiring the latest data.table version, but 🤷)

@sbfnk
Copy link
Contributor Author

sbfnk commented Nov 6, 2024

I don't think data.table has any dependencies apart from methods. One benefit of introducing a dependency on 1.16.0 is that we could also make the code introduced in #974 much more concise (and efficient) using fcase(). It seems fine to me to depend on a recent CRAN version, but if we think it's an issue then replacing the facse code with if/else statements also would not be a big deal.

@nikosbosse
Copy link
Contributor

Then maybe let's just depend on the most recent data.table version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants