You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
does that data.table version have any relevant dependencies? If not then I don't mind either way (maybe very slight preference for not requiring the latest data.table version, but 🤷)
I don't think data.table has any dependencies apart from methods. One benefit of introducing a dependency on 1.16.0 is that we could also make the code introduced in #974 much more concise (and efficient) using fcase(). It seems fine to me to depend on a recent CRAN version, but if we think it's an issue then replacing the facse code with if/else statements also would not be a big deal.
turns out this line in the new non-randomised PIT
scoringutils/R/metrics-sample.R
Line 582 in 0761099
relies on a fairly cutting-edge data.table version (1.16.0, released 25 August 2024) that supports a vector for
default
We either have to require this version as a minimum or change the code.
The text was updated successfully, but these errors were encountered: