Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename/refactor? assert_dims_ok_point #938

Open
nikosbosse opened this issue Oct 3, 2024 · 1 comment
Open

Rename/refactor? assert_dims_ok_point #938

nikosbosse opened this issue Oct 3, 2024 · 1 comment
Labels
low-priority refactor Code refactoring

Comments

@nikosbosse
Copy link
Contributor

The function is used for both binary and point forecasts, so we should make that clearer in the name.

In the spirit of having code for different forecasting classes more independent (at least in terms of how the code is organised) maybe some other approach is warranted as well. Don't have strong thoughts on this yet (or any, really...)

@seabbs
Copy link
Contributor

seabbs commented Oct 3, 2024

can we give it a name to make it clear the concept it is asserting and leave it at that as a utility function?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low-priority refactor Code refactoring
Projects
Development

No branches or pull requests

2 participants